Skip to content

Add some instructions for Claude regarding accessibility reviews #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-susanh wants to merge 1 commit into
base: develop
Choose a base branch
from
+14 −3
Open

Add some instructions for Claude regarding accessibility reviews #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .claude/commands/review-local.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ Compare what the code *actually does* (from Phase 2) against what it *should do*
- Are there other places in the codebase that should have been updated alongside this change?
- Are tests updated to cover the new behavior?

## Phase 6: Accessibility

- Are there missing labels, empty buttons, missing alt text, missing or inappropriate tab indexes, or other problems that make the new functionality
not accessible to all users and prevent us from being WCAG 2.2 A and AA compliant?

---

## Output Format
Expand All @@ -67,4 +72,4 @@ For each issue found, report:
> **Why it matters**: The impact if unfixed.
> **Suggestion**: How to fix it.

Lead with Critical and High severity issues. After all issues, give a one-paragraph overall assessment.
Lead with Critical and High severity issues. After all issues, give a one-paragraph overall assessment.
7 changes: 6 additions & 1 deletion .claude/commands/review-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ Compare what the code *actually does* (from Phase 2) against what it *should do*
- Are there other places in the codebase that should have been updated alongside this change?
- Are tests updated to cover the new behavior?

## Phase 6: Accessibility

- Are there missing labels, empty buttons, missing alt text, missing or inappropriate tab indexes, or other problems that make the new functionality
not accessible to all users and prevent us from being WCAG 2.2 A and AA compliant?

---

## Output Format
Expand All @@ -58,4 +63,4 @@ For each issue found, report:
> **Why it matters**: The impact if unfixed.
> **Suggestion**: How to fix it.

Lead with Critical and High severity issues. After all issues, give a one-paragraph overall assessment.
Lead with Critical and High severity issues. After all issues, give a one-paragraph overall assessment.
3 changes: 2 additions & 1 deletion .claude/skills/wcag-compliance/wcag-22-checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,12 @@ These patterns are common in the LabKey codebase and deserve extra attention:
- Check `Modal`/`ModalDialog` components trap focus and are dismissible via Escape.
- Ensure `Grid`/`QueryGrid` table components use proper `<table>` semantics with headers.
- Check custom dropdown/select components for keyboard navigation (arrow keys, Escape, Enter).
- Ensure tags other than buttons that have an `onClick` include an `onKeyDown` handler

### JSP Pages
- Verify `<labkey:form>` and `<labkey:input>` render with proper label associations.
- Check `<labkey:link>` and `<labkey:button>` produce accessible HTML.

### ExtJS Components
- ExtJS components often lack accessibility. Flag custom ExtJS widgets that have no ARIA markup.
- Verify ExtJS modals/windows are keyboard dismissible.
- Verify ExtJS modals/windows are keyboard dismissible.