Skip to content

Safe redirect action #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 1 commit into from
May 28, 2026
Merged

Safe redirect action #3023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/org/labkey/test/tests/DomainDesignerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.labkey.serverapi.collections.ArrayListMap;
import org.labkey.test.BaseWebDriverTest;
import org.labkey.test.Locator;
import org.labkey.test.WebTestHelper;
import org.labkey.test.SortDirection;
import org.labkey.test.TestFileUtils;
import org.labkey.test.TestTimeoutException;
Expand Down Expand Up @@ -1902,6 +1903,47 @@ public Map<String, Object> getConditionalFormats(PropertyDescriptor column, Stri
return conditionalFormat;
}

@Test // GitHub Issue #1023
public void testNoExternalReturnUrlRedirect() throws Exception
{
String listName = "ExternalRedirectTestList";
TestDataGenerator dgen = new TestDataGenerator("lists", listName, getProjectName())
.withColumns(List.of(new FieldDefinition("testField", FieldDefinition.ColumnType.String)));
dgen.createDomain(createDefaultConnection(), "IntList", Map.of("keyName", "id"));

// Verify a valid local returnUrl is used as expected
String localReturnUrl = WebTestHelper.buildURL("query", getProjectName(), "begin");
beginAt(WebTestHelper.buildURL("core", getProjectName(), "domainDesigner",
Map.of("schemaName", "lists", "queryName", listName, "returnUrl", localReturnUrl)));
DomainDesignerPage domainDesignerPage = new DomainDesignerPage(getDriver());
domainDesignerPage.fieldsPanel();
domainDesignerPage.clickCancel();
String postCancelUrl = getDriver().getCurrentUrl();
assertTrue("Cancel with a local returnUrl should redirect to the specified local page",
postCancelUrl.contains("query-begin.view"));

// Navigate to domain designer with an external returnUrl. The safeRedirect action
// should prevent external redirects, falling back to the local home page instead.
List<String> domainDesignerUrls = new ArrayList<>();
domainDesignerUrls.add(WebTestHelper.buildURL("core", getProjectName(), "domainDesigner",
Map.of("schemaName", "lists", "queryName", listName, "returnUrl", "https://labkey.com")));
domainDesignerUrls.add(WebTestHelper.buildURL("list", getProjectName(), "editListDefinition", Map.of("returnUrl", "https://labkey.com")));
domainDesignerUrls.add(WebTestHelper.buildURL("experiment", getProjectName(), "editSampleType", Map.of("returnUrl", "https://labkey.com")));
domainDesignerUrls.add(WebTestHelper.buildURL("experiment", getProjectName(), "editDataClass", Map.of("returnUrl", "https://labkey.com")));
for (String domainDesignerUrl : domainDesignerUrls)
{
beginAt(domainDesignerUrl);
domainDesignerPage = new DomainDesignerPage(getDriver());
domainDesignerPage.fieldsPanel();
domainDesignerPage.clickCancel();
postCancelUrl = getDriver().getCurrentUrl();
assertFalse("Cancel with an external returnUrl should not navigate to an external site",
postCancelUrl.contains("labkey.com"));
assertTrue("Cancel with an external returnUrl should redirect to a local LabKey page instead of: " + postCancelUrl,
WebTestHelper.isTestServerUrl(postCancelUrl));
}
}

@Override
protected BrowserType bestBrowser()
{
Expand Down