Skip to content

🔤 fix: Resolve Programmatic Tool Sandbox Names - #708

Merged
danny-avila merged 3 commits into
mainfrom
lia/issue-18211
Nov 18, 2026
Merged

danny-avila merged 3 commits into
mainfrom
lia/issue-18211

Conversation

@lia-by-librechat

@lia-by-librechat lia-by-librechat Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Hyphenated MCP tools are registered with hyphens but exposed as underscored sandbox functions. Using the sandbox name in tool_manifest was rejected before execution.

  • Accept unambiguous Bash/Python sandbox names alongside registered names in manifests.
  • Preserve registered definitions and executable identities for remote and local runners.
  • Show concrete runtime names. For collisions, retain registered-name manifests to avoid selecting another server's tool.
  • Preserve direct-only restrictions and reject ambiguous aliases.

Refs LibreChat-AI/LibreChat#18211. LibreChat needs a released agents version containing this fix.

Verification

  • Focused Jest: 500 tests passed across eight suites, including real Bash/Python calls and local/Cloudflare backends.
  • TypeScript (tsc --noEmit), touched-file ESLint, and import-order checks passed.
  • Package build, circular-dependency check, and 18 light-entry tests passed.
  • Initial P2 review finding fixed in 2bdd59d820dc662d7fb0988d735ba650cb445a99; independent review complete on this head with no new findings.
  • Live Code API integration tests not run.

@lia-by-librechat

Copy link
Copy Markdown
Contributor Author

Head: 102044cd62fb1b23012e36618643b847d78b29f6. Accepts unambiguous sandbox names in Bash/Python manifests, retains registered tool identities, and adds concrete prompt mappings with caller-policy regressions.

@lia-by-librechat

lia-by-librechat Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Head: d5d07206fc7ba5a2006b6dc01d767f024f544cd6. Fixes the local regression assertion to read ToolMessage content. All 303 focused tests pass, including real Bash/Python bridge calls; TypeScript and touched-file lint checks pass.

@lia-by-librechat

lia-by-librechat Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Head: 2bdd59d820dc662d7fb0988d735ba650cb445a99.

Independent review complete. P2 R1 (colliding manifest guidance) is fixed in this head. No new findings.

Verification: 500 focused Jest tests, TypeScript, touched-file lint/import order, package build, circular-dependency check, and 18 light-entry tests passed. Live Code API integration tests were not run locally.

@danny-avila

Copy link
Copy Markdown
Collaborator

@codex review the latest head, final review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T12:38:39.922097Z 2bdd59d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 2bdd59d820

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit c082ba8 into main Nov 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants