Repository navigation
🔤 fix: Resolve Programmatic Tool Sandbox Names - #708
Conversation
|
Head: |
|
Head: |
|
Head: Independent review complete. P2 R1 (colliding manifest guidance) is fixed in this head. No new findings. Verification: 500 focused Jest tests, TypeScript, touched-file lint/import order, package build, circular-dependency check, and 18 light-entry tests passed. Live Code API integration tests were not run locally. |
|
@codex review the latest head, final review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Hyphenated MCP tools are registered with hyphens but exposed as underscored sandbox functions. Using the sandbox name in
tool_manifestwas rejected before execution.Refs LibreChat-AI/LibreChat#18211. LibreChat needs a released agents version containing this fix.
Verification
tsc --noEmit), touched-file ESLint, and import-order checks passed.2bdd59d820dc662d7fb0988d735ba650cb445a99; independent review complete on this head with no new findings.