Repository navigation
feat: exact-match tool_search, skill discoveries, and linked subagent traces - #712
Closed
zeyutao-ubi-solutions wants to merge 1 commit into
Conversation
… traces Hosts that defer MCP tools cannot rely on BM25 top-5 to load a known name, and skill artifacts must bind the same way as tool_search. Child subagent runs also need their own Langfuse AgentRun plus an optional content-parts hook so media is not a process-global. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Opened in error; these changes stay in our product fork and are not intended for upstream. |
zeyutao-ubi-solutions
deleted the
feat/tool-search-exact-match-and-subagent-host-hooks
branch
November 18, 2026 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_searchnow exact-matches a full name, underscored base name, orselect:query against the full registry before BM25, and reports already-bound tools asalready_availableinstead of ranking deferred siblings.extractToolDiscoveriesalso readsskillartifacts (tool_references) so SOP-named tools bind on the next turn.AgentRunwith parent link metadata, honor an optionaltimeoutMs, and acceptgetAdditionalContentPartsfor host media instead of a process-global hook. Graph invoke prefersmetadata.parentMessageIdand passestraceIdSeedinto the runtime scope.Test plan
src/tools/__tests__/ToolSearch.test.ts(exact match,select:, already available)src/messages/__tests__/tools.test.ts(skill artifact discoveries)src/tools/subagent/__tests__/SubagentExecutor.langfuse.test.ts(child AgentRun metadata + content parts)npx tsc --noEmitMade with Cursor