Skip to content

fix(ci): make workflow-sync token selection follow one resolved auth mode - #118

Draft
vitormattos wants to merge 7 commits into
mainfrom
fix/workflow-sync-auth-mode-20261117
Draft

vitormattos wants to merge 7 commits into
mainfrom
fix/workflow-sync-auth-mode-20261117

Conversation

@vitormattos

@vitormattos vitormattos commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Change the shared workflow-sync template to use only the neutral github-app, token, and github-token authentication modes.
  • Use WORKFLOW_SYNC_APP_CLIENT_ID, WORKFLOW_SYNC_APP_PRIVATE_KEY and WORKFLOW_SYNC_TOKEN exclusively. No aliases or fallback to organization-branded credentials remain.
  • Keep one GitHub App token creation step and fail closed when the required credential is missing.
  • Update the npm audit workflow, upstream refresh workflow, their generated/upstream patches, contract tests and catalog documentation.
  • Do not change external Nextcloud repositories, credentials or GitHub settings in this PR.

Verification

  • Python tests, actionlint, zizmor, workflow policy and DCO passed at the latest reviewed HEAD.
  • The generated Nextcloud-derived patches reconstruct their corresponding catalog workflows.
  • The PR diff contains no new organization-branded credential references.
  • All commits are incremental, DCO-compliant and cryptographically verified.

Dependent consumer migrations

Required before merging consumer PRs

GitHub Actions secrets cannot be read back or renamed using the connected GitHub access. Administrators must provision the new variable and private-key secret with the correct GitHub App identity and installation permissions; consumers using numeric App IDs must supply the actual App Client ID. Verify a controlled run before retiring the previous settings.

Merge the catalog PR first (without squash); keep dependent consumer PRs as drafts until credentials have been verified.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…gacy fallback

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…h template

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ic settings

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant