Skip to content

fix: keep apps enabled for everyone when enabling them for a group - #39

Merged
vitormattos merged 1 commit into
mainfrom
fix/keep-apps-enabled-for-everyone
Nov 14, 2026
Merged

vitormattos merged 1 commit into
mainfrom
fix/keep-apps-enabled-for-everyone

Conversation

@YvesCesar

Copy link
Copy Markdown
Member

Purpose

EnableAppsForGroup read the app enabled value with getValueArray, which returns an empty list when the value is yes. For an app enabled for everyone, the job then saved [<group>, "admin"], restricting the app to the new group and to admins and removing it from every other user.

Changes

  • When the app is already enabled for everyone (yes), keep it as is and only apply the LibreSign request sign setting.
  • Ignore items of appIds that are not strings.

Verification

  • Psalm, PHP CS Fixer and PHP lint pass locally.
  • The repository has no PHPUnit or Behat suite yet, so this was checked against a local Nextcloud 33: after provisioning a group with an app enabled for everyone and running the queued job, the app stays enabled for everyone.

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
@YvesCesar
YvesCesar force-pushed the fix/keep-apps-enabled-for-everyone branch from 41cef4d to 71a9ab1 Compare November 14, 2026 15:20
@vitormattos
vitormattos merged commit 5e27cf5 into main Nov 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants