Repository navigation
fix(ci): upgrade Psalm and the coding standard to run on PHP 8.5 - #41
Merged
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
vitormattos
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
static-psalm-analysisandphp-csjobs run on the newest PHP version the app supports, whichnextcloud-version-matrixnow resolves to PHP 8.5. Both tools pinned invendor-binfail there:$value must be a scalarwhile reflecting theRoundingModeenum added in PHP 8.4. 5.26.1 is the last 5.x release.Changes:
vendor-bin/psalm: Psalm^6.20, which supports PHP 8.1 to 8.5. Its platform goes from8.1to8.1.31, the lowest 8.1 patch release Psalm 6 accepts;phpVersioninpsalm.xmlstays at 8.1.#[\Override]to the four methods Psalm 6 flags withMissingOverrideAttribute, as LibreSign does, and drop theUndefinedDocblockClasssuppression that is no longer triggered.vendor-bin/coding-standard:nextcloud/coding-standard^1.4, which brings php-cs-fixer 3.95 with PHP 8.5 support.The workflows themselves are untouched, so the template sync does not overwrite this.
Verified locally on PHP 8.5.12 with
nextcloud/ocp:dev-stable35, the same setup as CI:composer run psalmandcomposer run cs:check(withoutPHP_CS_FIXER_IGNORE_ENV) both pass.