Skip to content

Add regression coverage for legacy CA identifier parsing #9472

Closed

Description

@vitormattos

Goal

Add deterministic regression tests for legacy LibreSign CA identifiers, protecting current OpenSSL and CFSSL behavior before the multi-CA registry is introduced.

Current implementation

Start with:

  • lib/Service/CaIdentifierService.php
  • tests/php/Unit/Service/CaIdentifierServiceTest.php

Existing tests already cover CA ID generation, some validation cases and one OpenSSL PKI-directory name. They do not thoroughly assert the parsed fields returned by getCaIdParsed() or cover both engine types in directory-name generation.

Scope

Extend the existing unit test class with named data providers where helpful. Verify:

  • Correct parsing through public getCaIdParsed() for legacy OpenSSL (_e:o) and CFSSL (_e:c) IDs, including instanceId, generation, engineType and engineName.
  • Expected directory paths from generatePkiDirectoryName() for both engine types and representative generations.
  • Rejection of malformed or unsupported IDs by the public parsing path.
  • Preservation of the existing ID shape and output without modifying production code.

Use synthetic identifiers and mocked IAppConfig. Do not invoke private methods directly or generate real CA keys.

Acceptance criteria

  • Tests cover both engines and at least one positive and negative parsing scenario.
  • Assertions compare all important parsed fields and exact directory-name outputs, not just non-null values.
  • Tests fail when the legacy parsing or directory-path contract is unintentionally changed.
  • Existing CaIdentifierServiceTest remains deterministic and passes.
  • No production CA logic, public identifier format, storage layout or CRL URL is modified.

Tests

Run composer test:unit -- --filter CaIdentifierServiceTest and applicable PHP syntax/static checks. Include the command results in the PR.

Next steps in the parent epic (not this task)

The multi-CA epic will later create a persistent issuer registry, retain compatibility with these legacy identifiers, and introduce context-aware CA operations and CRL routing. These tests are a baseline for compatibility, not the new registry implementation.

Good first issue

All work stays inside an established PHPUnit test class with a small public service contract. Follow its existing DataProvider examples. No database, encryption, authorization or CA lifecycle changes are required. Check for an active PR; questions and coordination are optional.

Additional context

Activity

  1. added theissue type on Nov 13, 2026
  2. matheusa1 commented on Nov 15, 2026

    @matheusa1
    Contributor

    Hi! I’d like to work on this. My plan is to extend the existing CaIdentifierServiceTest only, with named data providers covering getCaIdParsed() for _e:o and _e:c (all four parsed fields), exact generatePkiDirectoryName() outputs for both engines, and malformed IDs (empty, unknown engine, wrong prefix, bad generation, uppercase instance id) using expectException without asserting messages. No production code changes. If I find edge cases where current behavior looks questionable (e.g. $ accepting a trailing newline, leading zeros in the generation), I’ll leave them out of the PR and report them separately rather than pinning them. Is that scope OK?

  3. moved this from 0. Backlog to 4. Done in LibreSign Roadmapon Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Fields

    Priority

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions