Repository navigation
Conversation
…envelopes getNextcloudFiles() left the folder service on the file owner, so the visible element lookup of later envelope children ran as the owner and failed for guest signers. signSequentially() also re-signed children already signed by the same signer on retry, stacking signatures.
|
Thanks for opening your first pull request in this repository! ✌️ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9538
Two changes in
SignFileService:getNextcloudFiles()switched the folder service to the file owner and never restored it. Later lookups for the next envelope child (visible elements of a guest signer) then ran as the owner and failed with "You need to define a visible signature or initials to sign this document." The previous user is now restored in afinally.signSequentially()skips a child whose sign request is already signed, so a retried request cannot stack signatures on an already-signed child.Tests: added
testGetNextcloudFilesRestoresFolderServiceUserId. The unit suite was not run locally (no composer/vendor in this environment); relying on CI.The same code is present on
stable35; a backport may be wanted.