Skip to content

fix: restore folder service user and skip already signed children in envelopes - #9539

Open
no84by wants to merge 1 commit into
LibreSign:mainfrom
no84by:fix/envelope-signer-context
Open

no84by wants to merge 1 commit into
LibreSign:mainfrom
no84by:fix/envelope-signer-context

Conversation

@no84by

@no84by no84by commented Nov 18, 2026

Copy link
Copy Markdown

Fixes #9538

Two changes in SignFileService:

  • getNextcloudFiles() switched the folder service to the file owner and never restored it. Later lookups for the next envelope child (visible elements of a guest signer) then ran as the owner and failed with "You need to define a visible signature or initials to sign this document." The previous user is now restored in a finally.
  • signSequentially() skips a child whose sign request is already signed, so a retried request cannot stack signatures on an already-signed child.

Tests: added testGetNextcloudFilesRestoresFolderServiceUserId. The unit suite was not run locally (no composer/vendor in this environment); relying on CI.

The same code is present on stable35; a backport may be wanted.

…envelopes

getNextcloudFiles() left the folder service on the file owner, so the
visible element lookup of later envelope children ran as the owner and
failed for guest signers. signSequentially() also re-signed children
already signed by the same signer on retry, stacking signatures.
@no84by
no84by requested a review from a team as a code owner November 18, 2026 02:05
@welcome

welcome Bot commented Nov 18, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request in this repository! ✌️

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Envelope: guest signer gets 'You need to define a visible signature or initials' on the 2nd document; retries stack signatures

1 participant