Repository navigation
Conversation
Add the signed_copy_mail policy (disabled by default). When enabled for the requester, a completed request queues one mail per recipient in the notification delivery outbox: - each signer the requester chose with the new sendSignedCopy signer field (a switch in the signer editor); - the optional archive addresses configured in the policy. For an envelope each recipient gets one mail with all of their documents: a signer gets the documents they signed, archive addresses get every document. The delivery key is derived from the request and the recipient, so a repeated completion never mails a recipient twice. The DeliverNotification job reads the signed PDFs at send time. When the documents of one mail exceed 15 MiB, or a signed file cannot be read, the mail links to the validation page instead. Signed-off-by: no84by <50858621+no84by@users.noreply.github.com>
|
Thanks for opening your first pull request in this repository! ✌️ |
Author
|
Overview of a related set of changes, each reviewable on its own:
Screenshots for the UI changes follow in each PR. |
Author
|
Screenshots (test instance on main 7a8403d vs this branch, light and dark theme): Policy card "Email the signed document" (enabled, archive addresses)
Add-signer dialog: new switch
Mail after the last signature: signed PDF attached
Link fallback for a large document
Rule dialog with the switch and archive addresses
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
















Resolves: #9545
Related: #7986 (separate completion notifications), #8497 (completion callback).
Summary
Adds an opt-in way to mail the fully signed PDF after the last signature. Today only the requester gets a "document signed" link.
signed_copy_mail(system/group/user, disabled by default):{"enabled": bool, "archive_addresses": [..]}.sendSignedCopy(API + a switch in the signer editor, shown only while the policy is enabled for the requester).SigningRequestCompletedEvent, one delivery per recipient is registered in the notification delivery outbox (signed_copyevent,mailchannel) and sent byDeliverNotification, so attempts are recorded, lost jobs are recovered byRecoverPendingNotifications, and the outcome webhook applies. Chosen signers get the documents they signed, archive addresses get every document; for an envelope this is one mail per recipient with all of their documents.Existing installs: nothing changes until an admin enables the policy.
How to test
Validation evidence
SignedCopyMailServiceTestincl. a repeated completion,SignedCopyAttachmentProviderTest,NotificationChannelsTest,SignedCopyMailPolicyTest,SignedCopyMailPolicyValueTest,SignedCopyMailListenerTest, new cases inMailServiceTest,RequestSignatureServiceTest,FileListServiceTest; Vitest specs for the policy module,IdentifySigner, files store)ts:check, eslint,lint:translator-hints)UI / Front-end changes
New policy card "Email the signed document" (switch + archive addresses field)
New switch in the signer editor
Screenshots before/after added for user-visible changes
Component/unit (Vitest) tests added or updated
Documentation updated when applicable
API / Back-end changes
sendSignedCopyonNewSigner(request) and on signer details (returned only to the requester)composer openapiChecklist
AI (if applicable)