Repository navigation
fix: bring the merged linked account and squatting fixes into main - #32
Merged
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…eates them Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…subadmins fix: refuse accounts named after a WordPress login unless an admin creates them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#30 and #31 were opened as a stack on top of #29. #29 was merged into
main, but #30 was then merged intofix/add-command-to-link-wordpress-usersand #31 intofix/require-wordpress-link, so neither reachedmain. This PR takesfix/require-wordpress-linkintomain. It carries both and adds no other change.What reaches
mainwordpress_loginpreference is exactly its uid and a WordPress user has exactly thatuser_login. The password listener runs onPasswordUpdatedEventand writes back only for linked accounts. Default queries match the exact login, byte for byte.user_login. Administrators, delegated administrators and creation without a session (occ, background jobs) are not affected.Merge and deploy order
mainwith fix: stop subadmins from adding users of other groups to their groups admin_group_manager#35.occ wordpress-login-backend:link-users --dry-run, check the output, then run it without--dry-runbefore deploying this, otherwise existing customers lose the WordPress login.Verification
mainwithout conflicts.