hal: fix bugs in the hal-streamer interface and implementation#3885
Merged
andypugh merged 1 commit intoLinuxCNC:masterfrom Mar 29, 2026
Merged
hal: fix bugs in the hal-streamer interface and implementation#3885andypugh merged 1 commit intoLinuxCNC:masterfrom
andypugh merged 1 commit intoLinuxCNC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the HAL stream interface and implementation. There were several issues. One error was that the buffer count would be off-by-one whenever the buffer content wrapped the buffer. There were several issues wit atomicity and the handling of different types was incomplete. The PR also removes private structural definitions from public headers and moves them to the only place they are used inside the source.
The halmodule python interface was cleaned up and, in addition to fixing the stream functionality. Unnecessary/invalid use and casting of
hal_*_ttypes are removed and now use the proper hal union dereferences. Also, several python sized type conversions (in build value) were fixed where there were several copy-and-paste errors using the same signed 'l' conversion for both signed, unsigned and 32-bit and 64 bit conversions ('l', 'k', 'L' and 'K'). These now use the proper conversion type markers, including fixing 'f' (float) and 'd' (double) confusion.