Skip to content

hm2_eth: don't abort board load when SIOCSARP is denied #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grandixximo wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

hm2_eth: don't abort board load when SIOCSARP is denied #4112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/hal/drivers/mesa-hostmot2/hm2_eth.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,11 +759,17 @@ static int init_board(hm2_eth_t *board, const char *board_ip) {
return ret;
}

// Pinning the ARP entry needs CAP_NET_ADMIN; rootless without setcap
// fails with EPERM. Best-effort, not fatal: fall back to dynamic ARP
// so the board still loads. Clear ATF_PERM so the SIOCDARP teardown
// in close_board() does not try to remove an entry we never set.
ret = ioctl_siocsarp(board);
if(ret < 0) {
LL_PRINT("ERROR: ioctl SIOCSARP failed: %s\n", strerror(errno));
LL_PRINT("WARNING: ioctl SIOCSARP failed: %s; continuing with "
"dynamic ARP. Install file capabilities (sudo make "
"setcap) or run setuid to pin the board's ARP entry and "
"avoid occasional transmit latency.\n", strerror(errno));
board->req.arp_flags &= ~ATF_PERM;
return -errno;
}

// install_iptables_board() is a no-op when iptables is unavailable
Expand Down
Loading