Skip to content

master gremlin: Initialize preview interpreter with active modal gcodes #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sigma1912 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

master gremlin: Initialize preview interpreter with active modal gcodes #4123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/emc/usr_intf/gremlin/gremlin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ def load(self,filename = None):
canon.parameter_file = temp_parameter

unitcode = "G%d" % (20 + (s.linear_units == 1))
# fix Incorrect preview for arcs and absolute encoders
initcode = "G53 G0 "
for i in range(9):
if s.axis_mask & (1<<i):
Expand All @@ -336,8 +337,15 @@ def load(self,filename = None):
pos = s.position[i] % 360.000
else:
pos = s.position[i]
position = " %s%.8f" % (axis, pos)
position = "%s%.8f " % (axis, pos)
initcode += position
# To guard against incorrect preview with incomplete preambles in the gcode program
# we initialize with active gcodes for modal groups 2,3,4,5,6,7,8,9,10,11,12,13,14,15
# sorting is not necessary but helps in debugging
active_gcodes = s.gcodes
for i in (3,6,14,7,5,4,9,12,10,16,8,11,13,15):
if active_gcodes[i] > -1:
initcode = initcode + 'G' + str(active_gcodes[i]/10) + ' '
result, seq = self.load_preview(filename, canon, unitcode, initcode)
if result > gcode.MIN_ERROR:
self.report_gcode_error(result, seq, filename)
Expand Down
Loading