Repository navigation
feat(components): per-model selector lookup and Devin speed as Fast - #2759
Draft
EventHorizonXT wants to merge 1 commit into
Draft
EventHorizonXT wants to merge 1 commit into
EventHorizonXT wants to merge 1 commit into
Conversation
Two pieces of ACP selector plumbing needed by per-model config pickers (Refs LodyAI#2758): builtin Devin carries Fast on a `speed` select rather than a fast-mode toggle, so normalize it the same way — keep the select when the model declares Fast and filter it when it does not. And add `useAcpModelSelectorResolver`, exposed as `selectorsForModel` on the session selector context, so callers can resolve the config options an arbitrary model would show without changing the current selection. Model: swe-2-max Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This was referenced Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Refs #2758
Problem / pressure
Two gaps in the ACP selector plumbing block any per-model configuration picker
(the Devin Fusion builder in #2758 is the first consumer):
speedconfig select rather than a booleanfast-mode toggle like Codex/Claude.
normalizeFastModeSelectorsneitherrecognized that select as an existing Fast control nor filtered it for
models whose declaration omits Fast, so the Fast state leaked across Devin
models with different capabilities.
changing the current selection. A picker that compares controls across
models had to borrow the selected model's selectors, mixing capabilities.
Summary
acp-selector-options.ts: treat builtin Devin'sspeedselect as theper-model Fast control inside the existing
normalizeFastModeSelectorspass — kept when the model declares
fastMode, filtered when it does not,gated to builtin Devin only via
BUILTIN_SELECT_FAST_CONFIG_IDS.use-acp-selector-options.ts: adduseAcpModelSelectorResolver, a purelookup returning the selectors, source and adapter declaration an arbitrary
model id would get, without touching the current selection.
use-session-acp-selector-context.ts: expose it asselectorsForModel.speednormalization covered intests/acp-selector-options.test.ts(offered → kept, not offered →filtered, non-Devin agents untouched).
Visual explanation
Before / after
speedselect ignored by Fast normalization; models without declared Fast kept showing itspeedtreated exactly like the Fast toggles: kept when declared, filtered when not, builtin Devin onlyselectorsForModel(modelId)resolves any model's selectors, source and declaration without changing selectionTest plan
pnpm --filter @lody/components exec vitest run tests/acp-selector-options.test.ts— 36 tests pass, including the new Devinspeedcases.pnpm --filter @lody/components typecheck— clean.pnpm checkon the full feature branch — clean; this PR is the first slice of it.Context handoff
Original user prompt
Show original prompt
Shared conversation
Status: shared
Link: https://share.lody.ai/s/r17fb89p3ppc0qj99rkbb566z98j5ypd#access=v1.33791ff0455b99e33f50af2f1d22541dc0fa58c70b61266a0b3e3303df06f4b1