Repository navigation
Conversation
- packageManager を pnpm@12.15.0 に、CONTRIBUTING の記載を pnpm 12.x に - pnpm 12 は allowBuilds に無い依存の postinstall があると install を止めるため、 pnpm 10 でも動いていなかった @vscode/vsce-sign・keytar を allowBuilds で false に - pnpm-lock.yaml に pnpm 自身の版の文書(packageManagerDependencies)が足された。部品の版は変えていない Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDZzA8fkAc11hCSdTfZeXh
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変えたこと
package.jsonのpackageManagerをpnpm@12.15.0にCONTRIBUTING.mdの「pnpm 10.x」を「pnpm 12.x」にpnpm-workspace.yamlのallowBuildsに'@vscode/vsce-sign': false・keytar: falseを足したERR_PNPM_IGNORED_BUILDSで install が止まる。これまでどおり動かさない形で明示したpnpm-lock.yamlの先頭に pnpm 自身の版の文書(packageManagerDependencies)が足された5 つの workflow の pnpm/action-setup@v5 はどれも
version指定なしで packageManager を読むので、workflow は変えていない。確かめたこと
pnpm -vが 12.15.0pnpm install --frozen-lockfileが通るlockfileVersion: '9.0'のまま、既存部分の削除・変更は 0 行で、足されたのは先頭の文書だけpnpm lint・format:check・build・check:tsdoc・typecheck・test(core 393 / cli 29 / rehype 14 / react 9 / vue 8 / astro 4 / editor 22 ほか)すべて通るpnpm --filter kumihimo-vscode exec vsce package --no-dependenciesで vsix が作れる(vsce-sign の postinstall を動かさなくても問題ない)pnpm audit:93 件(low 11 / moderate 39 / high 39 / critical 4)。この PR では直していない気づいたこと(この PR では触っていない)
pnpm buildするとpackages/obsidian/manifest.jsonの version が 1.1.13 → 1.1.15 に書き換わる(main の manifest.json が package の版と合っていない)🤖 Generated with Claude Code
https://claude.ai/code/session_01QDZzA8fkAc11hCSdTfZeXh