Skip to content

style: fix format:check on dev after merging #272 and #274 - #275

Merged
sasagar merged 1 commit into
devfrom
style/format-after-273
Oct 13, 2026
Merged

sasagar merged 1 commit into
devfrom
style/format-after-273

Conversation

@sasagar

@sasagar sasagar commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

#274 のブランチは #272 の vp fmt 設定(printWidth 120)が入る前に作ったため、両方をマージした後の dev で format:check が失敗するようになりました。対象は DragonflyCacheAdapter.ts と ActivityDeliveryQueue.ts の 2 行です。

この PR は vp fmt を適用しただけで、動作は変わりません。

🤖 Generated with Claude Code

Summary by CodeRabbit

  • 変更
    • キャッシュとアクティビティ配信キューの Redis 接続先の選択処理を整理しました。接続先の優先順位や既定値に変更はありません。

#274 was branched before the 120-column vp fmt config landed in #272,
so the merged dev fails format:check on these two lines.
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Love-Rox/rox/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 474322fa-8320-4c22-a826-e7992a69cc7c
📥 Commits

Reviewing files that changed from the base of the PR and between 2893837 and d0935cb.

📒 Files selected for processing: 2
  • packages/backend/src/adapters/cache/DragonflyCacheAdapter.ts
  • packages/backend/src/services/ap/ActivityDeliveryQueue.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

DragonflyCacheAdapter と ActivityDeliveryQueue で、Redis接続URLの選択式を1行にまとめました。環境変数と既定URLの選択優先順位に変更はありません。

Changes: Redis接続URLの代入形式

Layer / File(s) Summary
接続URLの選択式を整理
packages/backend/src/adapters/cache/DragonflyCacheAdapter.ts, packages/backend/src/services/ap/ActivityDeliveryQueue.ts
両方のコンポーネントで接続URLの選択式を1行にまとめました。REDIS_URL、DRAGONFLY_URL、既定URLの優先順位は維持されています。

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to d0935

This change only reformats the Redis URL selection expressions; the configured URL precedence and fallback remain unchanged, so no actionable merge risk is identified.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed タイトルは、#272 と #274 のマージ後に発生した format:check の失敗を修正する変更内容を正確に示しています。変更対象がフォーマットのみであることとも一致します。
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sasagar
sasagar merged commit 450b6cd into dev Oct 13, 2026
11 checks passed
@sasagar
sasagar deleted the style/format-after-273 branch October 13, 2026 23:16
This was referenced Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant