Repository navigation
Conversation
auto-tag pushes tags with RELEASE_PAT, which also triggers release.yml. Both workflows then created the same release and raced on the SBOM upload. Add a guard job that skips push events whose annotated tag was created by github-actions[bot]; hand-pushed tags and workflow_dispatch are unaffected. Claude-Session: https://claude.ai/code/session_01Y29fBeRP344FME6de48wUv
fix: skip Manual Release for tags pushed by auto-tag
Node.js 20 reached end-of-life on 2026-04-30. Node is only used in the devcontainer to install the Claude Code CLI via npm. Claude-Session: https://claude.ai/code/session_01Y29fBeRP344FME6de48wUv
- Add lib/redis.ts with shared URL resolution, protocol: 2 and a never-give-up reconnect strategy (capped at 5s) for both the cache adapter and the delivery queue - Wait up to 15s for the first ready event instead of failing on the first connection error, so a late Dragonfly start no longer disables the queue and cache for the process lifetime - Log a warning once per outage and an info message on recovery - Generate job IDs from a SHA-256 digest with a d- prefix: no collisions between deliveries and never integer-like (rejected by BullMQ) Claude-Session: https://claude.ai/code/session_01Y29fBeRP344FME6de48wUv
#281) - Drop --cache_mode=true so Dragonfly never evicts queue keys; every cache entry already sets a TTL - Start the backend only after Dragonfly is healthy - Comment out REDIS_URL in .env.example so a copied .env does not override the DRAGONFLY_URL set by compose and the devcontainer Claude-Session: https://claude.ai/code/session_01Y29fBeRP344FME6de48wUv
@simplewebauthn/server v14 exports AuthenticatorTransport itself. Claude-Session: https://claude.ai/code/session_01Y29fBeRP344FME6de48wUv
auto-tag now adds an "[auto-tag]" marker to the tag message and the release.yml guard checks for it, so the two workflows no longer depend on the git user.name string alone. The tagger check remains as a fallback for tags created before the marker. Claude-Session: https://claude.ai/code/session_01Y29fBeRP344FME6de48wUv
The startup timeout error included the raw REDIS_URL/DRAGONFLY_URL, which can contain a password and is logged at warn level. Claude-Session: https://claude.ai/code/session_01Y29fBeRP344FME6de48wUv
…de24 chore: bump devcontainer Node.js from 20 to 24
fix: Redis/Dragonfly connection resilience and job ID collisions
fix: mark auto-tag tags explicitly for the release guard
chore: bump version to 2026.10.1
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v2026.10.1
Promote dev to main for the v2026.10.1 patch release (packages: 1.10.1).
Highlights since v2026.10.0
d-prefix — no collisions between deliveries and never integer-like (rejected by BullMQ) (fix: Redis/Dragonfly connection resilience and job ID collisions #284)--cache_mode=trueso BullMQ keys are never evicted; backend waits for a healthy Dragonfly;.env.exampleno longer overridesDRAGONFLY_URL(fix: Redis/Dragonfly connection resilience and job ID collisions #284)release.ymlskips tags created by auto-tag (explicit[auto-tag]marker) to stop the duplicate release / SBOM upload race (release.yml が auto-tag のタグでも動き、auto-tag と同時にリリースを作ろうとして競合する #278, fix: skip Manual Release for tags pushed by auto-tag #279, release.yml の auto-tag 判定を tagger 名の文字列比較に頼らないようにする #282, fix: mark auto-tag tags explicitly for the release guard #285)@simplewebauthn/types(fix: Redis/Dragonfly connection resilience and job ID collisions #284)Dragonfly cache connected/Redis connected, using BullMQ for delivery queueUpgrade notes for self-hosters (docker compose)
docker/compose.ymlno longer runs Dragonfly with--cache_mode=true. If you keep your own compose file, remove that flag so queued deliveries are not evicted under memory pressure..envwas copied from.env.exampleand setsREDIS_URL=redis://localhost:6379, remove it inside compose so the backend usesDRAGONFLY_URL.Merging this PR triggers auto-tag to create
v2026.10.1and the GitHub release. This is also the first release where therelease.ymlguard should skip the auto-tag tag.https://claude.ai/code/session_01Y29fBeRP344FME6de48wUv