Lobby stuff#9
Open
andreiBe wants to merge 19 commits into
Open
Conversation
-Asks password when connecting to lobby -Separated lobby into multiple components that only depend on their props -Added join server button -Joining a lobby disconnects the player from the current lobby -Handling errors that can happen when joining the lobby
-Server list indicates if the user does not have the correct game version installed -Removed old lobby store -Added currentInstance to lobby store
I found the video for Ying on this website: https://www.desktophut.com/Ying-Animated-Windows-Background-Wallpaper The video is probably in the game files too but I could not find it. Increased the number of columns on the champion select to fit ying without scrolling.
New images and backgrounds are needed for the newer champions
Separated the display name and the "real" name that is used in TempestMP and the game's console commands.
-Map selector shows maps based on version -Fixed scrolling on mapselector -New maps -Map images from the latest game version's loadingscreen_SF.upk
-Implemented countdown for state changes in the lobby -Refactored the lobby server logic to use a state machine -UI for the countdown
-also combined some stores
-also added better defaults for the fields
-this functionality is disabled for now because the server would need to preload all champions -also made it possible to rejoin a lobby after being kicked for not selecting a champion
Lobbies should not fill up with people that do not leave the lobby because they are afk or they close the application. This commit tries to fix that while still allowing people a lot of time to get back because Paladins is a buggy game and requires a PC restart sometimes. - if player's client disconnects for more than 5 minutes --> client is kicked out (uses the event stream) - game server will close if all player's leave the lobby or are kicked out - if player tries to close the app while in a lobby --> asks if the user wants to leave the lobby before leaving - lobby stores are persistent so rejoining a lobby is possible - if the user is afk in the launcher (game closed) during the game they will be kicked after 5 minutes if they don't confirm they are still at their computer - instances are closed if the server is not running
all the oxlint rules did not work for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple improvements to the lobby system
-Asks password when connecting to lobby
-Separated lobby into multiple components that only depend on their props
-Added join server button
-Joining a lobby disconnects the player from the current lobby
-Handling errors that can happen when joining the lobby
-Server list indicates if the user does not have the correct game version installed
-Available champions and maps based on game version
-Countdown for lobby state transitions
-Build asm loader when the application is built
-Kicking afk players out of the lobby