Bump frankenphp + fix flacky test#4354
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdates the FrankenPHP production stage: replaces the base image digest and adds OS packages; adjusts a photo tags test to sort tags before asserting to avoid order dependence. ChangesMaintenance and Test Reliability
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/ImageProcessing/Photo/PhotoTagsTest.php (1)
143-145: 💤 Low valueConsider using
assertEqualsCanonicalizingfor cleaner order-independent comparison.PHPUnit provides
assertEqualsCanonicalizing()which compares arrays regardless of order, eliminating the need for manual sorting.♻️ Suggested refactor
- $sorted_tags = $response->json('photos.0.tags'); - sort($sorted_tags); - $this->assertEquals(['tag1', 'tag2'], $sorted_tags); + $this->assertEqualsCanonicalizing(['tag1', 'tag2'], $response->json('photos.0.tags'));
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f4fde681-9c2a-4c42-acff-1b9f550f85c6
📒 Files selected for processing (2)
Dockerfiletests/ImageProcessing/Photo/PhotoTagsTest.php
Summary by CodeRabbit
Chores
Tests