Skip to content

Bump frankenphp + fix flacky test#4354

Merged
ildyria merged 3 commits into
masterfrom
bump-frankenphp
May 18, 2026
Merged

Bump frankenphp + fix flacky test#4354
ildyria merged 3 commits into
masterfrom
bump-frankenphp

Conversation

@ildyria
Copy link
Copy Markdown
Member

@ildyria ildyria commented May 17, 2026

Summary by CodeRabbit

  • Chores

    • Updated the production runtime base image and added additional OS libraries to the deployment image.
  • Tests

    • Improved test stability by making photo tag assertions order-independent (sorting before assertion).

Review Change Stack

@ildyria ildyria requested a review from a team as a code owner May 17, 2026 08:49
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ea9786f0-e467-476a-931a-584bdc2c6fc1

📥 Commits

Reviewing files that changed from the base of the PR and between e91d24f and d44132a.

📒 Files selected for processing (1)
  • Dockerfile
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile

📝 Walkthrough

Walkthrough

Updates the FrankenPHP production stage: replaces the base image digest and adds OS packages; adjusts a photo tags test to sort tags before asserting to avoid order dependence.

Changes

Maintenance and Test Reliability

Layer / File(s) Summary
FrankenPHP production image and packages
Dockerfile
Production stage FROM digest for dunglas/frankenphp:php8.5-trixie updated; added libcap2, libcap2-bin, libnghttp2-14, libsystemd0, libudev1 to apt-get install.
Photo tags test ordering fix
tests/ImageProcessing/Photo/PhotoTagsTest.php
testTagsPhotoAuthorizedOwnerPreserveNoOverride now extracts photos.0.tags, sorts the array, and asserts the sorted tags equal ['tag1','tag2'], removing reliance on JSON ordering.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped the Docker lanes at dusk,
Updated digest, tidied the husk.
Packages added, tidy and neat,
Tags sorted now—no scrambled tweet.
A grateful rabbit nibbles a treat.

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/ImageProcessing/Photo/PhotoTagsTest.php (1)

143-145: 💤 Low value

Consider using assertEqualsCanonicalizing for cleaner order-independent comparison.

PHPUnit provides assertEqualsCanonicalizing() which compares arrays regardless of order, eliminating the need for manual sorting.

♻️ Suggested refactor
-		$sorted_tags = $response->json('photos.0.tags');
-		sort($sorted_tags);
-		$this->assertEquals(['tag1', 'tag2'], $sorted_tags);
+		$this->assertEqualsCanonicalizing(['tag1', 'tag2'], $response->json('photos.0.tags'));

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f4fde681-9c2a-4c42-acff-1b9f550f85c6

📥 Commits

Reviewing files that changed from the base of the PR and between c5f7a37 and d130d89.

📒 Files selected for processing (2)
  • Dockerfile
  • tests/ImageProcessing/Photo/PhotoTagsTest.php

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bb67b1b6-ab59-4e4f-bb31-c62b78c2e322

📥 Commits

Reviewing files that changed from the base of the PR and between d130d89 and e91d24f.

📒 Files selected for processing (1)
  • Dockerfile

Comment thread Dockerfile Outdated
@ildyria ildyria merged commit 1216753 into master May 18, 2026
46 checks passed
@ildyria ildyria deleted the bump-frankenphp branch May 18, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant