Skip to content

feat: custom album pack navigation shortcuts, Hot Reload support, and compatibility fixes#28

Open
Suzimo506 wants to merge 3 commits into
MDMods:masterfrom
Suzimo506:master
Open

feat: custom album pack navigation shortcuts, Hot Reload support, and compatibility fixes#28
Suzimo506 wants to merge 3 commits into
MDMods:masterfrom
Suzimo506:master

Conversation

@Suzimo506
Copy link
Copy Markdown

This Pull Request introduces several quality-of-life enhancements, UI shortcuts, performance optimizations, Hot Reload support, and compatibility fixes.

Key Features & Changes:

  1. Album Pack & UI Navigation Enhancements

    • Added shortcuts (Ctrl + A/D and Ctrl + Left/Right Arrow keys) to quickly scroll and switch between custom album packs in the level select UI.
    • Added dynamic pack title prefixes to first songs and unclassified songs to visually categorize folder directories.
    • Optimized GetPackTitle performance and fixed scroll wrapping behavior.
    • Implemented a sequential GIF preloading queue to prevent random game crashes when loading animated covers.
    • Replaced unsafe memory copying methods with a safe loop copy in CopyFromManaged to eliminate heap corruption and crash issues.
  2. Hot Reload Functionality

    • Implemented a full Hot Reload feature for custom charts, enabling reloading of custom albums in-game.
    • Fixed leaderboard display and flash/crash issues associated with reloading.
    • Fixed a bug where hot-reloaded custom charts failed to load their hidden sheets.
  3. Localization & Compatibility

    • Added localization adaptation matching the current game language.
    • Compatible with HiddenQoL one-key toggle and resolved issues with the Hidden mode.

@flustix
Copy link
Copy Markdown
Member

flustix commented Jun 4, 2026

While I can't review this, I have looked at it and noticed some things:

  • You didn't change the metadata of the mod back. (specifically the name)
  • Don't put comments in chinese or any language other than english.

@Suzimo506
Copy link
Copy Markdown
Author

While I can't review this, I have looked at it and noticed some things:

  • You didn't change the metadata of the mod back. (specifically the name)
  • Don't put comments in chinese or any language other than english.

thanks for ur opinion.i have fixed the problems u said

@ALLMarvelous
Copy link
Copy Markdown
Member

Hi, thanks for the PR! In the future, please use the development branch as your head as we have our unreleased changes there.

I have a handful of personal stashed changes I plan to commit on top of the commits left behind in the dev branch, so it will be difficult to review this until we are at that point.

On top of that, this pull is absolutely massive (27 files changed) featuring several modifications of different types which directly goes against our organization's contribution guidelines (1 PR = 1 change) as it makes it far too difficult to pick through which of these changes are acceptable and which ones are not. Please consider this in future pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants