Draft
Conversation
* rename the test group to slm_circ_icesheet * move the convergence test to a test case called slm_circ_icesheet_mesh_convergence. * Move resources and modules around This is to support a separate smoketest that will reuse modules and resources.
This is a second test case in the test group that runs a simple smoke test.
2cc557c to
7c64344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the landice/slm test group to support the existing mesh convergence test, as well as a new smoke test. The smoke test sets up and runs the SLM coupled within MALI for the circular ice sheet geometry (a prescribed ice-sheet evolution case with no ice-sheet dynamics). This approximates running the SLM in standalone mode and is suited for an integration test.
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes