Repository navigation
feat: gzip rotated logs and bound diagnostic retention - #35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MistEO
added a commit
to MaaXYZ/MaaFramework
that referenced
this pull request
Nov 13, 2026
任务结束后调度 MaaUtils 的后台日志维护，使用 gzip level 6 压缩轮转备份，并清理过期或超出预算的历史诊断文件。轮转阈值提高到 128 MiB，沿用现有的轮转检查时机。 - 更新 MaaUtils 子模块，包含压缩、保留策略及 Windows 进程退出处理。 - 中英文问题反馈文档仅补充 `.log.gz` 备份的上传说明。 - 新增 9 项回归测试，覆盖压缩、轮转阈值、保留期限、容量淘汰、写入失败、符号链接和压缩期间退出后恢复。 验证：本地 422 项单元测试通过；[Windows、Linux、macOS CI 测试全部通过](https://github.com/MaaXYZ/MaaFramework/actions/runs/43408175447)，[8 个平台构建及 Node.js、NuGet、Python 打包全部通过](https://github.com/MaaXYZ/MaaFramework/actions/runs/43408175591)。 配套 [MaaUtils #35](MaaXYZ/MaaUtils#35) 已合并，子模块固定至合并提交 `af3fce72982c009ad55c02f47b41e13082738eb9`。最终仅调整子模块提交引用，已核对 Utils 源码树与上述 CI 测试的版本完全一致。 AI 使用信息： - Agent：codex - 模型：gpt-6-astra - 思考强度：max ## Sourcery 摘要 在任务完成后保留并维护压缩后的诊断日志，同时增加保留策略保护，并为上传归档日志提供用户指引。 错误修复： - 通过压缩符合条件的备份，在维护或压缩失败时安全保留文件，确保任务完成后仍可保留诊断日志。 功能增强： - 将日志轮转阈值提高至 128 MiB，并对历史日志和诊断文件应用保留策略及存储预算清理，同时保护活动日志、无关文件和符号链接。 文档： - 更新英文和中文故障排查指南，支持上传压缩的 `.log.gz` 备份。 测试： - 增加回归测试，覆盖压缩、轮转阈值、保留策略、基于预算的清理、故障恢复、中断的维护操作以及符号链接处理。 杂项： - 更新 MaaUtils 子模块，纳入日志维护和 Windows 进程退出处理方面的更改。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Preserve and maintain compressed diagnostic logs after task completion while adding retention safeguards and user guidance for uploading archived logs. Bug Fixes: - Maintain diagnostic logs after task completion by compressing eligible backups and safely preserving files when maintenance or compression fails. Enhancements: - Raise log rotation to 128 MiB and apply retention and storage-budget cleanup for historical logs and diagnostic artifacts while protecting active logs, unrelated files, and symlinks. Documentation: - Update English and Chinese troubleshooting guidance to support uploading compressed `.log.gz` backups. Tests: - Add regression coverage for compression, rotation thresholds, retention, budget-based cleanup, failure recovery, interrupted maintenance, and symlink handling. Chores: - Update the MaaUtils submodule to include the log maintenance and Windows process-exit handling changes. </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
将日志轮转阈值从 16 MiB 提高到 128 MiB，复用现有 zlib，以 gzip level 6 在后台压缩已完成轮转的日志，减少历史诊断文件占用。
验证：Linux/Clang 20 本地构建及 422 项单元测试通过；Windows、Linux、macOS CI 测试全部通过，其中 9 项日志测试覆盖压缩、轮转、保留期限、容量淘汰、写入失败、符号链接和压缩期间退出。Windows x86_64/ARM64 构建通过。
配套 PR：https://github.com/MaaXYZ/MaaFramework/pull/1621。先合并本 PR，再将 MaaFramework 子模块更新至合并后的提交。
AI 使用信息：