Skip to content

MDEV-39043: ENUM can be set to empty string by giving an index value as string "0" #4793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grooverdan merged 2 commits into from
Apr 14, 2026
Merged

MDEV-39043: ENUM can be set to empty string by giving an index value as string "0" #4793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a2737e
MDEV-39043: String '0' sets the ENUM to an empty string
HNOONa-0 Apr 11, 2026
6db56c1
Merge branch '10.11' into MDEV-39043
grooverdan Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mysql-test/main/type_enum.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2616,4 +2616,17 @@ a b
2 N
drop table t1;
set sql_mode=default;
#
# MDEV-39043 ENUM can be set to empty string by giving an index value as string "0"
#
set sql_mode=STRICT_ALL_TABLES;
create table t1 (a enum('Value1', 'Value2') NOT NULL DEFAULT 'Value1');
insert into t1 values ('0');
Comment thread
HNOONa-0 marked this conversation as resolved.
ERROR 01000: Data truncated for column 'a' at row 1
insert into t1 values (0);
ERROR 01000: Data truncated for column 'a' at row 1
select * from t1;
a
drop table t1;
set sql_mode=default;
# End of 10.11 tests
Expand Down
13 changes: 13 additions & 0 deletions mysql-test/main/type_enum.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,4 +617,17 @@ select * from t1;
drop table t1;
set sql_mode=default;

--echo #
--echo # MDEV-39043 ENUM can be set to empty string by giving an index value as string "0"
--echo #
set sql_mode=STRICT_ALL_TABLES;
create table t1 (a enum('Value1', 'Value2') NOT NULL DEFAULT 'Value1');
--error WARN_DATA_TRUNCATED
insert into t1 values ('0');
--error WARN_DATA_TRUNCATED
insert into t1 values (0);
select * from t1;
drop table t1;
set sql_mode=default;

--echo # End of 10.11 tests
Expand Down
2 changes: 1 addition & 1 deletion sql/field.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9455,7 +9455,7 @@ int Field_enum::store(const char *from,size_t length,CHARSET_INFO *cs)
/* This is for reading numbers with LOAD DATA INFILE */
char *end;
tmp=(uint) cs->strntoul(from,length,10,&end,&err);
if (err || end != from+length || tmp > typelib->count)
if (err || end != from+length || !tmp || tmp > typelib->count)
{
tmp=0;
set_warning(WARN_DATA_TRUNCATED, 1);
Expand Down