MDEV-38791: Disallow duplicate weekday formats in TO_DATE#4810
Open
alexDiaconuAlex wants to merge 1 commit intoMariaDB:12.3from
Open
MDEV-38791: Disallow duplicate weekday formats in TO_DATE#4810alexDiaconuAlex wants to merge 1 commit intoMariaDB:12.3from
alexDiaconuAlex wants to merge 1 commit intoMariaDB:12.3from
Conversation
alexDiaconuAlex
force-pushed
the
MDEV-38791-fix-12.3
branch
2 times, most recently
from
ac82c2b to
f99b235
Compare
gkodinov
added
the
External Contribution
gkodinov
requested changes
Mar 16, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
Please make the commit message compliant with CODING_STANDARDS.md
| } | ||
| else if (tmp1 == 'Y') | ||
| { | ||
| if (for_to_date && formats_used(&used, FMT_DAY)) |
Member
There was a problem hiding this comment.
You sure you just need to check for FMT_DAY? IMHO more is needed.
| { | ||
| if (ptr + 2 == end || my_toupper(system_charset_info, *(ptr+2)) != 'Y') | ||
| goto error; | ||
| if (for_to_date && formats_used(&used, FMT_DAY)) |
mysql-test/main/mdev_38791.test
Outdated
| @@ -0,0 +1,4 @@ | |||
| SET sql_mode='ORACLE'; | |||
|
|
|||
| SELECT TO_DATE('Monday Mon', 'DAY DY'); | |||
Member
There was a problem hiding this comment.
Please add all of the queries mentioned into the JIRa. Also please extend the test suite will all the additional combos you can think of. E.g. IYYY etc.
alexDiaconuAlex
force-pushed
the
MDEV-38791-fix-12.3
branch
from
f99b235 to
c9b8d7b
Compare
The Oracle-mode TO_DATE() function incorrectly parsed strings containing duplicate or conflicting format specifiers (e.g., 'YYYY YYYY', 'DAY DY', or 'AM PM') without throwing an ER_STD_INVALID_ARGUMENT error. This patch introduces family-based conflict checks in item_timefunc.cc during format string parsing. It leverages the formats_used bitmask to ensure that specifiers sharing the same logical time bucket strictly block each other: * Year family: Y, YY, YYY, YYYY, RR, RRRR, SYYYY * Month family: MM, MON, MONTH, RM, DDD * Day family: D, DD, DY, DAY, DDD * Hour family: HH, HH12, HH24 * Meridian family: AM, PM, A.M., P.M. Compatible specifiers, such as YYYY and DDD (Year and Day of Year), remain unaffected and parse successfully. A comprehensive MTR test suite has been added to cover standard and edge-case conflicts. Reported-by: Elena Stepanova <elenastepanova@github> Signed-off-by: Alexandru Diaconu <alexandrudiaconu93@gmail.com>
alexDiaconuAlex
force-pushed
the
MDEV-38791-fix-12.3
branch
from
c9b8d7b to
c169b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
TO_DATEwithsql_mode='ORACLE', providing duplicate weekday format specifiers (such as'DAY DY') did not throw an error during the format string parsing phase.Solution
Added duplicate format checks for weekday specifiers in
parse_format_string()(insidesql/item_timefunc.cc).Now, inputs like
SELECT TO_DATE('Monday Mon', 'DAY DY') FROM DUAL;correctly fail early and returnERROR 3047 (HY000): Invalid argument error: date format not recognized at DY in function to_date.Reported-by: Elena Stepanova elenastepanova@github