MDEV-38792: Fix inconsistent separator treatment in TO_DATE#4811
Open
alexDiaconuAlex wants to merge 1 commit intoMariaDB:12.3from
Open
MDEV-38792: Fix inconsistent separator treatment in TO_DATE#4811alexDiaconuAlex wants to merge 1 commit intoMariaDB:12.3from
alexDiaconuAlex wants to merge 1 commit intoMariaDB:12.3from
Conversation
alexDiaconuAlex
force-pushed
the
MDEV-38792-fix-final-12.3
branch
2 times, most recently
from
8bd25e4 to
e196a0d
Compare
alexDiaconuAlex
force-pushed
the
MDEV-38792-fix-final-12.3
branch
from
e196a0d to
9748047
Compare
Member
|
prelim review - #general > MDEV-31535 @ 💬 |
gkodinov
added
the
External Contribution
gkodinov
requested changes
Mar 16, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
Please add a commit message that compiles with CODING_STANDARDS.md.
Member
|
Also, please fix all the buildbot failures. compat/oracle.func_to_date looks related. |
alexDiaconuAlex
force-pushed
the
MDEV-38792-fix-final-12.3
branch
3 times, most recently
from
4ba0a2f to
4067cf5
Compare
Oracle and MariaDB allow leeway in using different separators between date string and format elements. However, MariaDB would return NULL or throw a warning if the date string had extra non-alphanumeric separators (like a dash) that the format string didn't have. This patch adds logic to skip non-alphanumeric characters in the date string before matching the next token. To avoid breaking existing functionality, it specifically safeguards the '-' sign only when the expected format is SYYYY to preserve negative year parsing. Reported-by: Elena Stepanova <elenastepanova@github> Signed-off-by: Alexandru Diaconu <alexandrudiaconu93@gmail.com>
alexDiaconuAlex
force-pushed
the
MDEV-38792-fix-final-12.3
branch
from
4067cf5 to
39fa757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed MDEV-38792: Added a loop to skip non-alphanumeric separators in TO_DATE, ensuring flexible data parsing matching Oracle's expected behavior.
Reported-by: Elena Stepanova elenastepanova@github