MDEV-39086 MSAN/UBSAN/ASAN builds run without basic optimization (fix)#4818
Open
grooverdan wants to merge 1 commit intoMariaDB:10.6from
Open
MDEV-39086 MSAN/UBSAN/ASAN builds run without basic optimization (fix)#4818grooverdan wants to merge 1 commit intoMariaDB:10.6from
grooverdan wants to merge 1 commit intoMariaDB:10.6from
Conversation
As noted the MSVC supports a different range of optimization flags and
therefore not setting -Og.
When CMAKE_BUILD_TYPE is specified its in a mixed case, but the
CMAKE_C{,XX}_FLAGS_${BUILD_TYPE} is always upper case.
Thanks Vlad for noticing.
grooverdan
added
the
MariaDB Foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted the MSVC supports a different range of optimization flags and therefore not setting -Og.
When CMAKE_BUILD_TYPE is specified its in a mixed case, but the CMAKE_C{,XX}FLAGS${BUILD_TYPE} is always upper case.