Add Dark Mode Support by yihao03 · Pull Request #2856 · MarkBind/markbind

yihao03 · 2026-03-11T08:22:54Z

Upgrade Bootstrap to 5.3 for dark theme support
Refresh CLI functional outputs for dark mode
Add runtime page theme switching
Add dark mode toggle and component overrides
Update tests

What is the purpose of this pull request?

Overview of changes:
This is (edit: started off as) a fully vibe coded PR with (edit: has been tweaked and optimized since) minimal manual tweak to showcase what dark mode on a markbind sites can look like. The changes made include:

Upgrading Bootstrap to 5.3 for dark theme support
Add css for Vue components to support dark mode
Add a dark mode flag in site.json. By default, the dark mode respect user's
system preference.
Add a toggle button in the navbar to allow users to switch between light
and dark mode

Anything you'd like to highlight/discuss:
Screenshots to be added later

Testing instructions:
pull this branch, run npm run setup and serve a markbind site to see the
changes.

Proposed commit message: (wrap lines at 72 characters)
Add Dark Mode support

Checklist: ☑️

Updated the documentation for feature additions and enhancements
Added tests for bug fixes or features
Linked all related issues
No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

Major (when you make incompatible API changes)
Minor (when you add functionality in a backward compatible manner)
Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

what was the old feature that was made obsolete

any replacement feature (if any), and

how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Move MarkBind onto Bootstrap 5.3.8 and the matching Bootswatch release so the site can use Bootstrap's native theme switching instead of custom one-off overrides. This establishes the asset baseline needed for runtime dark mode without changing page behavior yet.

Update the checked-in functional expectations after the Bootstrap upgrade and theme-aware page rendering changes. This records the new generated HTML and bundled assets so future CLI regressions are measured against the dark-mode-capable output.

Teach page generation to load both light and dark highlight themes, set the Bootstrap theme before styles paint, and apply dark-safe defaults to built-in templates. This keeps the initial render in sync with the chosen theme and avoids flashes of mismatched UI.

yihao03 · 2026-03-18T06:33:18Z

For dark mode support, the website looks cohesive and basic features are already present too. I guess a good step forward would be releasing this as an experimental feature and ask for bug reports for visual artifacts? Perhaps we can include a message along the lines of:

Hi! We have added dark mode to MarkBind sites. You can toggle it using the button in upper right corner. Please report any issues and submit feedbacks at [github issue link]

in the bottom banner of the page where we currently have "Website generated by MarkBind...`

what do yall think? @MarkBind/active-3281-members

damithc · 2026-03-18T08:07:47Z

For dark mode support, the website looks cohesive and basic features are already present too. I guess a good step forward would be releasing this as an experimental feature and ask for bug reports for visual artifacts? Perhaps we can include a message along the lines of:

Hi! We have added dark mode to MarkBind sites. You can toggle it using the button in upper right corner. Please report any issues and submit feedbacks at [github issue link]

in the bottom banner of the page where we currently have "Website generated by MarkBind...`

what do yall think? @MarkBind/active-3281-members

While getting end users to do the testing is the trend now 😆, we should do our own testing first.
You can deploy a few sample sites (e.g., CS2103 site, MarkBind site, se-edu/guides) in your own account and get others (e.g., other CS3281 students) to do a test-drive.

codecov · 2026-03-18T13:55:40Z

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.11%. Comparing base (b641bc9) to head (2d34770).

Files with missing lines	Patch %	Lines
packages/vue-components/src/DarkModeToggle.vue	95.83%	1 Missing ⚠️
packages/vue-components/src/Searchbar.vue	0.00%	1 Missing ⚠️
packages/vue-components/src/panels/NestedPanel.vue	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2856      +/-   ##
==========================================
+ Coverage   71.04%   71.11%   +0.07%     
==========================================
  Files         131      132       +1     
  Lines        7117     7143      +26     
  Branches     1683     1621      -62     
==========================================
+ Hits         5056     5080      +24     
- Misses       1961     1963       +2     
  Partials      100      100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR introduces dark mode support across MarkBind-generated sites by switching to Bootstrap 5.3’s data-bs-theme mechanism, updating component/template styles to be theme-aware, and adjusting page generation + test fixtures to support runtime theme selection (including code highlighting theme assets).

Changes:

Add runtime theme resolution (system preference + localStorage) and set data-bs-theme during initial page load; load both light/dark highlight stylesheets and toggle them at runtime.
Update Vue component and core-web CSS to use Bootstrap CSS variables and add dark-mode-specific overrides.
Refresh CLI functional expected outputs and template assets to match the new generated HTML/CSS behavior.

Reviewed changes

Copilot reviewed 145 out of 203 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
packages/vue-components/src/Tabset.vue	Add dark-mode print border override for tabset rendering.
packages/vue-components/src/TabGroup.vue	Add dark-mode print border override for tab groups.
packages/vue-components/src/Tab.vue	Add dark-mode print border override for tab headers.
packages/vue-components/src/Submenu.vue	Switch submenu text color to Bootstrap theme variable.
packages/vue-components/src/SiteNavButton.vue	Switch hamburger bar color to Bootstrap theme variable.
packages/vue-components/src/SiteNav.vue	Replace hardcoded nav colors with Bootstrap theme variables.
packages/vue-components/src/Searchbar.vue	Add dark-mode background override for `.table-active` rows.
packages/vue-components/src/panels/NestedPanel.vue	Adjust default panel background behavior and add dark-mode bg-light overrides.
packages/vue-components/src/panels/MinimalPanel.vue	Replace hardcoded colors with Bootstrap theme variables for dark mode.
packages/vue-components/src/PageNavButton.vue	Switch button dot color to Bootstrap theme variable.
packages/vue-components/src/Overlay.vue	Add dark-mode background for open overlay menu.
packages/vue-components/src/index.js	Register the new `DarkModeToggle` component.
packages/vue-components/src/cardstack/CardStack.vue	Add dark-mode text color overrides for badges/results count.
packages/vue-components/src/Breadcrumb.vue	Add dark-mode text color override for breadcrumb “notlink” items.
packages/vue-components/src/Box.vue	Add dark-mode alert overrides and align divider colors with alert border variables.
packages/core/test/unit/utils/data.ts	Update mocked page template assets to include both highlight stylesheets.
packages/core/template/project/stylesheets/main.css	Remove inline `mark` styling and add dark-mode template overrides.
packages/core/template/portfolio/stylesheets/main.css	Remove inline `mark` styling and add dark-mode template overrides.
packages/core/template/default/stylesheets/main.css	Remove inline `mark` styling and add dark-mode template overrides.
packages/core/src/Site/SitePagesManager.ts	Generate both highlight asset paths (light/dark) in page config.
packages/core/src/Site/LazyLiveReloadLoadingSite.html	Make loading screen colors responsive to `prefers-color-scheme`.
packages/core/src/patches/htmlparser2.ts	Treat `<dark-mode-toggle>` as a special tag for parsing.
packages/core/src/Page/PageConfig.ts	Update `PageAssets` to expose `highlightLight`/`highlightDark`.
packages/core/src/Page/page.njk	Add runtime theme resolution + dual highlight stylesheet toggling + set `data-code-theme`.
packages/core/package.json	Update Bootswatch version to match Bootstrap 5.3 series.
packages/core-web/src/styles/page-nav.css	Replace hardcoded nav colors with Bootstrap theme variables.
packages/core-web/src/styles/markbind.css	Add theme-aware `mark` styling and dark-mode overrides; adjust blockquote styles.
packages/cli/test/functional/test_site/expected/testTree.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testTooltipSpacing.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testThumbnails.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testPopoverTrigger.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testPopovers.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testPanels.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testPageNav.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testOcticonInPage.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testModals.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testMermaid.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testMath.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testMaterialIconsInPage.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testLinks.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testLayoutsOverride.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testLayouts.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testImages.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testIconsInSiteLayout.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testHr.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testGlyphiconInPage.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testFontAwesomeInPage.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testExternalScripts.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testEmptyFrontmatter.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testEmptyAltFrontMatter.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testDates.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testCodeBlocks.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/testBootstrapIconInPage.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/sub_site/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site/expected/bugs/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/userGuide/UserGuide.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/userGuide/QuickStart.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/userGuide/Features.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/userGuide/FAQ.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/team/johndoe.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/team/AboutUs.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/stylesheets/main.css	Update expected template CSS for dark-mode overrides and remove inline `mark` styling.
packages/cli/test/functional/test_site_templates/test_project/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/TracingCode.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/Testing.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/SettingUp.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/Requirements.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/Implementation.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/Documentation.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/DevOps.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/DeveloperGuide.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/Design.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_project/expected/developerGuide/Configuration.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_portfolio/expected/stylesheets/main.css	Update expected template CSS for dark-mode overrides and remove inline `mark` styling.
packages/cli/test/functional/test_site_templates/test_portfolio/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_minimal/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_default/expected/stylesheets/main.css	Update expected template CSS for dark-mode overrides and remove inline `mark` styling.
packages/cli/test/functional/test_site_templates/test_default/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_default/expected/contents/topic3b.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_default/expected/contents/topic3a.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_default/expected/contents/topic2.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_default/expected/contents/topic1.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_templates/test_default/expected/404.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_table_plugin/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_special_tags/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_3.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_2.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_1.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/README.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/Page-1.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/Home.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/contents/topic3b.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/contents/topic3a.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/contents/topic2.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/contents/topic1.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/about.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/404.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/Page-1.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/index.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/Home.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic3b.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic3a.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic2.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic1.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/about.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/404.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/_Sidebar.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
packages/cli/test/functional/test_site_convert/test_basic_convert/expected/_Footer.html	Update expected HTML to include theme scripts + dual highlight stylesheets + code-theme attribute script.
docs/njk/common.njk	Adjust docs navigation buttons styling for Bootstrap 5.3 theme compatibility.
docs/css/main.css	Remove inline `mark` styling (now handled centrally/theme-aware).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

packages/core-web/src/styles/markbind.css

packages/core/src/Page/page.njk

packages/vue-components/src/Searchbar.vue

packages/vue-components/src/cardstack/CardStack.vue

packages/vue-components/src/Tab.vue

packages/vue-components/src/Box.vue

darkmode is set to be opt in for now until mature However, if user's device is on dark mode, bootstrap will default to dark mode until javascript loads, then switch it to white mode

Handle disabling dark mode in page.njk. this avoids the stutter in the nav bar when the javascript loads

Use existing highlight color instead of --bs-hightlight-bg which affects readability.

Harjun751

Code-wise looks good to me!

A lot of switching from hardcoded values to variables (which is expected for something like this), and updating the few components that do have dark/light mode to use the "global" one.

Visually there's still some things to work through, documenting so we can create issues and work on it for the future:

Quiz components

Navbar presentation

We could add a white border.

FOUC is still a problem

show.mp4

Then after all the teething issues are worked out we can add it to the documentation and roll it out!

Harjun751 · 2026-03-28T02:33:24Z

packages/vue-components/src/cardstack/CardStack.vue

    }

+    [data-bs-theme="dark"] .badge.tag-badge.select-all-toggle {
+        color: #e9ecef !important;


Just curious, why is the approach for some of these components a little different?

I'm assuming this one has some color that's defined for light mode somewhere else, and this is a override once data-bs-theme="dark" is true.

Is there a reason why we can't use variables here too, like in other components?

Harjun751 · 2026-03-28T02:56:45Z

packages/core-web/asset/js/theme-manager.js

Harjun751 · 2026-03-28T03:00:31Z

packages/core-web/asset/js/code-theme.js

Hmm, for this would we not be able to dynamically load the correct stylesheet in the page.njk instead of loading both and disabling one here?

_{I'm unsure of the restrictions, so this might be the best way right now anyway.

I just think it would be good to (informally) document the design decision in this discussion}

Harjun751 · 2026-03-28T03:20:19Z

packages/core/src/Site/SiteConfig.ts


  plantumlCheck: boolean;

+  darkMode: boolean;


I don't remember if there was discussion on this, but should we nest this option within the "style" config option?

yihao03 added 6 commits March 9, 2026 13:21

Add dark mode toggle and component overrides

a1f02db

Update tests

19d5368

Update hard coded mark and blockquote colors

78dcb37

yihao03 added 5 commits March 18, 2026 19:04

Merge branch 'master' into feat/dark-mode

aa1c98f

Run npm i

403247f

Update page nav to use bootstrap colours

ddb44d9

Use bootstrap adaptive colors instead of hard coded value for nav

e419ccb

Update previous_next colour

60d6df8

yihao03 force-pushed the feat/dark-mode branch 4 times, most recently from 7bfd786 to f4104c5 Compare March 19, 2026 06:32

yihao03 marked this pull request as ready for review March 19, 2026 06:40

yihao03 requested a review from Copilot March 19, 2026 06:40

Copilot AI reviewed Mar 19, 2026

View reviewed changes

yihao03 added 7 commits March 20, 2026 11:53

Add adaptive theme for hot reload loading page

81801be

Add adaptive theme for panels

c9ac37d

Explicitly specify border colors for boxes

24bb019

Define mark in markbind.css instead of main.css

317f499

Build web and update tests

bf22300

Respect site.json for darkmode config

cd774d6

darkmode is set to be opt in for now until mature However, if user's device is on dark mode, bootstrap will default to dark mode until javascript loads, then switch it to white mode

Update tests

7260cdb

yihao03 force-pushed the feat/dark-mode branch from f4104c5 to 7260cdb Compare March 20, 2026 06:25

Merge branch 'master' into feat/dark-mode

883b5ef

yihao03 and others added 13 commits March 23, 2026 10:12

Merge branch 'master' into feat/dark-mode

08491f9

Update package lock

f109002

Use bs vars instead of theme overrides

c5ad891

Refactor panel to stop using isLightBg

c4af618

Remove conditional rendering in toggle vue

81d0684

Handle disabling dark mode in page.njk. this avoids the stutter in the nav bar when the javascript loads

Merge branch 'master' into feat/dark-mode

462aa72

Merge branch 'master' into feat/dark-mode

f37c491

Revert light mode highlight behavioural change

2d74dea

Use existing highlight color instead of --bs-hightlight-bg which affects readability.

Refactor inline scripts out of page.njk

e387406

Update tests

54ad07b

Merge branch 'master' into feat/dark-mode

0c02d85

Fixed thead divider regression

a0c16a7

Merge branch 'master' into feat/dark-mode

3732cdf

Harjun751 approved these changes Mar 28, 2026

View reviewed changes

Merge branch 'master' into feat/dark-mode

2d34770

Conversation

yihao03 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yihao03 commented Mar 18, 2026

Uh oh!

damithc commented Mar 18, 2026

Uh oh!

codecov bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harjun751 left a comment

Choose a reason for hiding this comment

Uh oh!

Harjun751 Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Harjun751 Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Harjun751 Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Harjun751 Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yihao03 commented Mar 11, 2026 •

edited

Loading

codecov bot commented Mar 18, 2026 •

edited

Loading