Enhance deployment output logs #2862
Conversation
Add specific authentication failure messages Add testcases
83ec257 to
c3bd90f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2862 +/- ##
==========================================
+ Coverage 70.96% 71.04% +0.07%
==========================================
Files 131 131
Lines 7085 7117 +32
Branches 1639 1653 +14
==========================================
+ Hits 5028 5056 +28
- Misses 2051 2055 +4
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Improves the deployment developer experience by detecting (and clearly messaging) GitHub Actions authentication pitfalls—especially when attempting cross-repository deployments using the default GITHUB_TOKEN.
Changes:
- Add auth-failure detection/wrapping and an early warning when GitHub Actions
GITHUB_TOKENis used for cross-repo deploys. - Add unit tests for the new auth/warning helpers and the GitHub Actions cross-repo warning path.
- Update the deployment guide with cross-repository PAT guidance and troubleshooting info.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/Site/SiteDeployManager.ts | Adds cross-repo token warning + auth error detection/wrapping around gh-pages publish failures |
| packages/core/test/unit/Site/SiteDeployManager.test.ts | Adds unit tests for auth error helpers and cross-repo warning behavior |
| docs/userGuide/deployingTheSite.md | Documents PAT requirement for cross-repo deployments and adds a troubleshooting tip |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
yihao03
left a comment
There was a problem hiding this comment.
LGTM! Just need abit clarification on the docs

What is the purpose of this pull request?
Overview of changes:
Adds some extra docs and logging for case of deploying to other repo.
Anything you'd like to highlight/discuss:
Thought i could resolve the incorrect success logging but turns out it is dependency issue.
New logs if deploying with default token to other repos:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Add deployment logs for token access
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):