Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the Xcode project’s transition to target-associated folders.
No open issues 🎉
What changed in this PR
This PR simplifies the Xcode project structure by replacing explicitly enumerated file groups with folder entries tied to their respective targets.
Changes:
- Converts
MarkEditMac/SourcesandMarkEditMac/Teststo folders with app and test target membership. - Converts
QuickLookMac/Extensionsto a folder with Quick Look target membership. - Removes the corresponding nested groups and per-file entries.
| File | Description |
|---|---|
MarkEdit.xcodeproj/project.xcproj |
Replaces three explicit file groups with target-associated folder entries. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.