Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The key-window observer can miss the initial window becoming key, leaving main-menu customization blocked until another key-window transition.
1 open issue
What changed in this PR
Adds lifecycle stages to AppDeferredTasks, allowing deferred AppKit setup to run after launch or when the first window becomes key.
Changes:
- Tracks readiness and queued actions independently for each stage.
- Defers recent-menu setup until launch finishes and main-menu customization until a window becomes key.
- Expands tests for stage isolation, reentrant actions, and repeated readiness signals.
| File | Description |
|---|---|
| MarkEditMac/Tests/AppDeferredTasksTests.swift | Tests both stages and their execution behavior. |
| MarkEditMac/Sources/Main/Application/AppDelegate.swift | Signals readiness at lifecycle events. |
| MarkEditMac/Sources/Main/AppDeferredTasks.swift | Adds stage-specific readiness and action queues. |
| MarkEditMac/Sources/Extras/NSDocumentController+Extras.swift | Assigns recent-menu setup to the launch stage. |
| MarkEditMac/Sources/Extras/NSApplication+Extras.swift | Assigns main-menu customization to the first-key-window stage. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Deferring the private AppKit menu hook until the first key window requires macOS launch and window-lifecycle validation that existing tests bypassing swizzling and observers do not provide.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.