Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The deferred newDocument: handling bypasses the menu item's target and responder chain, potentially creating a standard document instead of invoking the validated handler.
1 open issue
What changed in this PR
This PR works around an incorrect animation origin when Quick Search creates the first document by deferring the New action until after palette dismissal.
Changes:
- Adds an injectable menu-action handler to
QuickSearchController, preserving normal dispatch by default. - Defers standard New execution to the main queue in the application-specific handler.
- Extends activation tests to verify handler invocation for enabled actions and rejection of disabled actions.
| File | Description |
|---|---|
| MarkEditMac/Sources/Main/Application/AppDelegate+QuickSearch.swift | Defers New to avoid the document animation glitch. |
| MarkEditMac/Modules/Tests/QuickSearchMenuTests.swift | Checks custom dispatch invocation and disabled-action rejection. |
| MarkEditMac/Modules/Sources/QuickSearchUI/QuickSearchController.swift | Adds and invokes the configurable menu-action handler. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.