Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the changes to document synchronization and deferred edit notifications.
No open issues 🎉
What changed in this PR
This PR prevents stale native document text from being marked synchronized, while preserving deferred synchronization between the web editor and macOS document model.
Changes:
- Tracks content changes during text retrieval and preserves the outdated flag when retrieval fails or newer edits arrive.
- Preserves pending edit notifications across debounced selection updates and cancels completion when needed.
- Adds regression tests for synchronization failures, concurrent edits, and debounced notifications.
| File | Description |
|---|---|
MarkEditMac/Tests/EditorDocumentSaveTests.swift |
Tests failed retrieval and edits during synchronization. |
MarkEditMac/Sources/Editor/Models/EditorDocument.swift |
Clears the outdated flag only after successful retrieval without intervening changes. |
CoreEditor/test/utils/setup.ts |
Adds a native completion mock for input tests. |
CoreEditor/test/input.test.ts |
Tests pending edit notifications across selection changes. |
CoreEditor/src/modules/input/index.ts |
Retains pending edit state until notification and handles completion cancellation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.