Repository navigation
Make the library pass mypy --strict (v1.17.1) - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home Assistant core runs the
hr_energy_qubeintegration under strict typing, and the platinum quality scale asks for a typed library. The library already shipspy.typed, butmypy --strictreported 5 errors inclient.py. This fixes them and adds a strict mypy step to CI so it stays that way.read_value()types its register definition as(address, register type, data type, scale, offset), the shape of the tuples inconst.py._decode_registers()accepts theSequence[int]that pymodbus returns.read_entity()returnsfloat | int | bool | Noneinstead ofAny;read_binary_sensor()andread_switch()narrow that tobool | None. All binary sensors and switches are coils or discrete inputs, which already returned abool, so no return value changes.mypy --strict src/python_qube_heatpump(mypy pinned to 2.4.0); AGENTS.md lists the command.No API or behaviour change; version 1.17.1. Core can stay on its
==1.17.0pin.