Open
Conversation
📦 Build Artifacts Ready
|
Withalion
force-pushed
the
refactor/qt5compat-effects
branch
from
79d6f20 to
fff3cde
Compare
📦 Build Artifacts Ready
|
Withalion
added
the
performance
gabriel-bolbotina
requested changes
Mar 23, 2026
Contributor
gabriel-bolbotina
left a comment
gabriel-bolbotina
left a comment
There was a problem hiding this comment.
Looks good overall, just a few things to clarify
| QColor photoSketchingPinkColor() const {return QColor::fromString( "#FF8F93" );} | ||
|
|
||
| QColor shadowColor() const {return QColor::fromString( "#66777777" );} | ||
| QColor shadowColor() const {return QColor::fromString( "#4D000000" );} |
Contributor
There was a problem hiding this comment.
Why did you change the shadow color?
Contributor
Author
There was a problem hiding this comment.
Because the old one didn't produce shadow at all with the new approach. For the new approach only alpha channel is important and this color looked the most similar to the old one.
|
|
||
| // IconImage is not part of QML's public API, so this can break on Qt version change. | ||
| // However, if we don't want to use shaders, this is the most straightforward way. | ||
| IconImage { |
Contributor
There was a problem hiding this comment.
Is there a way to implement this so that it would work with a Qt version change?
Contributor
Author
There was a problem hiding this comment.
Well we can always use shaders to do that, but this might break. It doesn't mean it will break every Qt release.
gabriel-bolbotina
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes Qt5Compat effects and replaces them with
MultiEffector some other approach. From the crash reports looks like they trigger quite a lot of crashes for users.Only one reference to qt5compat has been left in
MMPhoto, which should be refactored in #4317