fix: add missing [autonomy] and [os] extras to [all] group#1632
fix: add missing [autonomy] and [os] extras to [all] group#1632praisonai-triage-agent[bot] wants to merge 1 commit intomainfrom
Conversation
The [all] extra group was missing [autonomy] and [os] extras, causing ImportError when users tried to use autonomy features after installing pip install 'praisonaiagents[all]'. This change adds both missing extras to ensure complete feature coverage: - [autonomy]: ast-grep-cli>=0.30.0 - [os]: FastAPI + uvicorn + PyJWT Co-authored-by: praisonai-triage-agent[bot] <praisonai-triage-agent[bot]@users.noreply.github.com>
|
@coderabbitai review |
|
/review |
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
✅ Actions performedReview triggered.
|
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR completes the ChangesOptional Dependencies Configuration
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly Related PRs
Suggested Labels
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copilot Do a thorough review of this PR. Read ALL existing reviewer comments above from Qodo, Coderabbit, and Gemini first — incorporate their findings. Review areas:
|
Greptile SummaryThis PR fixes a gap in
Confidence Score: 5/5Safe to merge — the change is two additive lines in the The only change is adding two self-referencing extras to the No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["pip install 'praisonaiagents[all]'"] --> B[all extras group]
B --> C[memory]
B --> D[knowledge]
B --> E[graph]
B --> F[llm]
B --> G[mcp]
B --> H[api]
B --> I[telemetry]
B --> J[mongodb]
B --> K[auth]
B --> L[search]
B --> M[crawl]
B --> N["autonomy NEW"]
B --> O["os NEW"]
N --> N1["ast-grep-cli>=0.30.0"]
O --> O1["fastapi>=0.115.0"]
O --> O2["uvicorn>=0.34.0"]
O --> O3["PyJWT>=2.8.0"]
H --> H1["fastapi>=0.115.0 overlap"]
H --> H2["uvicorn>=0.34.0 overlap"]
K --> K1["PyJWT>=2.8.0 overlap"]
Reviews (1): Last reviewed commit: "fix: add missing [autonomy] and [os] ext..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "praisonaiagents[crawl]", | ||
| "praisonaiagents[autonomy]", | ||
| "praisonaiagents[os]" | ||
| ] |
There was a problem hiding this comment.
[os] extra is fully covered by the [api] and [auth] extras that are already present in [all]. [api] provides fastapi and uvicorn; [auth] provides PyJWT (plus more). pip handles the overlap gracefully, so this is harmless — but the entry is redundant. The genuinely new dependency is [autonomy] (which brings in ast-grep-cli). If the intent is only to expose the os alias as a usable named extra, keeping it is reasonable; otherwise it could be omitted.
| "praisonaiagents[crawl]", | |
| "praisonaiagents[autonomy]", | |
| "praisonaiagents[os]" | |
| ] | |
| "praisonaiagents[crawl]", | |
| "praisonaiagents[autonomy]", | |
| "praisonaiagents[os]" # redundant: fastapi+uvicorn already in [api], PyJWT already in [auth] | |
| ] |
Reviewed commit 9accba1. No blockers found. The change is minimal and backward-compatible, with no security or performance concerns. Prior reviewer input was effectively: Qodo had no review, CodeRabbit had no actionable comments, and Greptile noted only that |
|
@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on Python packages (praisonaiagents, praisonai). Do NOT modify praisonai-rust or praisonai-ts. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding. Phase 1: Review per AGENTS.md
Phase 2: FIX Valid Issues Phase 3: Final Verdict |
|
Claude finished @MervinPraison's task —— View job Final Architecture ReviewPhase 1: Architecture Review per AGENTS.md
Phase 2: Address Valid Issues
Phase 3: Final Verdict
Architecture Review Findings✅ Phase 1: AGENTS.md Compliance
✅ Phase 2: Previous Reviewer IssuesGreptile's Valid Observation: The
However, this redundancy is architecturally acceptable because:
Action: No fix required - redundancy is intentional and harmless. ✅ Phase 3: Final VerdictAPPROVED ✅ This PR successfully addresses issue #1629 by:
Architecture Quality:
Recommendation: Merge immediately - this is a safe, focused fix that resolves the ImportError without any architectural concerns. |
Fixes #1629
Summary
The
[all]optional dependency group inpraisonaiagentswas missing the[autonomy]and[os]extras, causingImportErrorwhen users tried to use autonomy features after installing withpip install 'praisonaiagents[all]'.Changes
"praisonaiagents[autonomy]"to the [all] group (includesast-grep-cli>=0.30.0)"praisonaiagents[os]"to the [all] group (includes FastAPI, uvicorn, PyJWT)Impact
pip install "praisonaiagents[all]"will now get complete feature coveragefrom praisonaiagents.config import AutonomyConfigimport will work as expectedTest Plan
After this change, users should be able to:
pip install "praisonaiagents[all]"🤖 Generated with Claude Code
Summary by CodeRabbit