fix(keyring-snap-sdk): use KeyringRpc#561
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 19b3e50. Configure here.
mathieuartu
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use
KeyringRpcinstead ofKeyring(v2) type, since the Snap does not need to implement the fullKeyring(v2) interface, only a subset of it (KeyringRpc, just the RPC-callable methods basically)Note
Low Risk
Type-only API tightening in the Snap SDK with no change to RPC dispatch logic or security-sensitive paths.
Overview
handleKeyringRequest(v2) now types its keyring argument asKeyringRpcinstead of the full v2Keyring, matching what SnaponKeyringRequesthandlers actually need to implement (RPC-callable methods only, not client-side concerns likeserialize/deserialize/type/capabilities).Tests and the Unreleased changelog are updated accordingly; runtime dispatch behavior is unchanged.
Reviewed by Cursor Bugbot for commit be3cea9. Bugbot is set up for automated code reviews on this repo. Configure here.