Skip to content

fix(keyring-snap-sdk): use KeyringRpc#561

Merged
ccharly merged 3 commits into
mainfrom
cc/fix/use-keyring-rpc
May 29, 2026
Merged

fix(keyring-snap-sdk): use KeyringRpc#561
ccharly merged 3 commits into
mainfrom
cc/fix/use-keyring-rpc

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented May 29, 2026

Use KeyringRpc instead of Keyring (v2) type, since the Snap does not need to implement the full Keyring (v2) interface, only a subset of it (KeyringRpc, just the RPC-callable methods basically)


Note

Low Risk
Type-only API tightening in the Snap SDK with no change to RPC dispatch logic or security-sensitive paths.

Overview
handleKeyringRequest (v2) now types its keyring argument as KeyringRpc instead of the full v2 Keyring, matching what Snap onKeyringRequest handlers actually need to implement (RPC-callable methods only, not client-side concerns like serialize / deserialize / type / capabilities).

Tests and the Unreleased changelog are updated accordingly; runtime dispatch behavior is unchanged.

Reviewed by Cursor Bugbot for commit be3cea9. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly requested a review from a team as a code owner May 29, 2026 08:20
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 19b3e50. Configure here.

Comment thread packages/keyring-snap-sdk/src/v2/rpc-handler.test.ts
@ccharly ccharly enabled auto-merge May 29, 2026 08:30
@ccharly ccharly added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit 855ce82 May 29, 2026
40 checks passed
@ccharly ccharly deleted the cc/fix/use-keyring-rpc branch May 29, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants