feat(wallet): wire TransactionController into default initialization#8975
Draft
matthewwalsh0 wants to merge 11 commits into
Draft
feat(wallet): wire TransactionController into default initialization#8975matthewwalsh0 wants to merge 11 commits into
matthewwalsh0 wants to merge 11 commits into
Conversation
matthewwalsh0
force-pushed
the
feat/wallet-wire-transaction-controller
branch
4 times, most recently
from
c3042bb to
9677e31
Compare
matthewwalsh0
added a commit
that referenced
this pull request
Jun 2, 2026
matthewwalsh0
added a commit
that referenced
this pull request
Jun 3, 2026
matthewwalsh0
force-pushed
the
feat/wallet-wire-transaction-controller
branch
from
58d79cc to
0069b11
Compare
- Remove disableHistory and disableSendFlowHistory options - Replace getCurrentAccountEIP1559Compatibility with constant true - Replace getCurrentNetworkEIP1559Compatibility with NetworkController:getEIP1559Compatibility messenger call - Remove getExternalPendingTransactions (STX now routes through TransactionController) - Replace getGasFeeEstimates with GasFeeController:fetchGasFeeEstimates messenger call - Remove getNetworkClientRegistry option; inline messenger call in MultichainTrackingHelper - Replace getNetworkState with NetworkController:getState messenger call - Replace sign option with KeyringController:signTransaction messenger call; add txDataToTransaction helper - Remove transactionHistoryLimit option (now a feature flag) - Remove securityProviderRequest option and SecurityProviderRequest type export - Remove afterSimulate hook option and AfterSimulateHook type (unused in both clients) - Remove isResubmitEnabled option and all resubmit logic from PendingTransactionTracker
- Remove afterSign hook (unused in both clients) - Remove getAdditionalSignArguments hook (unused in both clients, also never called internally) - Remove afterSimulate hook (unused in both clients) - Move isTimeoutEnabled from hooks to root constructor options - Change serializeTransaction to accept TypedTxData directly via TransactionFactory.fromTxData - Remove txDataToTransaction helper; #updateTransactionMetaRSV now accepts TypedTxData
…ne ESLint suppressions
matthewwalsh0
force-pushed
the
feat/wallet-wire-transaction-controller
branch
from
4bf9b25 to
2aac690
Compare
matthewwalsh0
changed the base branch from
main
to
chore/remove-deprecated-tx-options
matthewwalsh0
force-pushed
the
chore/remove-deprecated-tx-options
branch
from
de6504d to
bfc8a1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds
packages/wallet/src/initialization/instances/transaction-controller/following the same pattern established by theapproval-controller/directory in #8953.The directory contains:
transaction-controller.ts— theInitializationConfigurationthat wiresTransactionControllerinto the default wallet initialization, delegating messenger actions from the root and creating a typed child messenger for the controllertypes.ts—TransactionControllerInitMessenger,TransactionControllerInitMessengerActions,TransactionControllerInitMessengerEvents, andTransactionControllerInstanceOptions(a subset ofTransactionControllerOptionsthat exposes only the genuinely platform-specific options; shared defaults are hardcoded in the config)References
Checklist