refactor: dedupe sentry trace#8994
Open
gambinish wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a4f810d. Configure here.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Gaps to close (likely in the sibling client PRs, not core)
late_success/late_erroris the taxonomy used, rather thantimeoutso some dashboards may need to be updated.usePerpsMeasurement({ traceName: PerpsOrderSubmissionToast })fromusePerpsOrderExecution.ts, deleting the PerpsOrderSubmissionToast TraceName from app/util/trace.ts, and the mobile-side Promise.race.References
Checklist
Note
Medium Risk
Changes order-placement tracing and timing behavior on a critical trading path; behavior intentionally avoids cancelling in-flight orders but dashboards and mobile UI must align on late_* reasons instead of client timeouts.
Overview
TradingService.placeOrdernow treatsPlaceOrderTimeoutMs(60s) as an observational threshold only: a timer fires a warning breadcrumb and flags slow submissions, but the code still awaitsprovider.placeOrderto completion (no client-side cancel /Promise.race), avoiding UI “failed” while HyperLiquid may still accept the order.endTracepayload gains optionalreason:late_success/late_errorwhen the provider finishes after the threshold, otherwiseerroron failures; timers are cleared infinally.Adds
PERPS_CONSTANTS.PlaceOrderTimeoutMs, removes unusedPerps Order Submission ToastfromPerpsTraceName, changelog updates, andTradingService.placeOrder.timeout.test.tsfor fast/late success and error paths.Reviewed by Cursor Bugbot for commit 30c06b9. Bugbot is set up for automated code reviews on this repo. Configure here.