Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
adds
kagi mail sendfor plain-text email using separateKAGI_MAIL_SMTP_USERNAMEandKAGI_MAIL_SMTP_PASSWORDcredentials. The transport requires certificate-verified STARTTLS. It does not reuse MCP OAuth tokens.Also fixes Windows-only test issues found while validating on Yoga.
why
Kagi documents SMTP as a supported mail protocol. The exact SMTP credential and authentication contract is still unverified, so this PR is a draft and must not be merged until that is confirmed.
test plan
cargo fmt -- --checkon Yoga: passedcargo clippy --all-targets --all-features -- -D warningson Yoga: passedcargo test --lockedon Yoga: passed (221 unit, 89 integration, 15 mail CLI; 13 ignored)ai assistance disclosure
agent_name: Hermes Agent and OMPagent_version: Hermes Agent v0.20.1; OMP 18.5.1model_used: gpt-6-luna and openai-codex/gpt-6.1-solhuman_testing: No human-run testing. Automated checks were run by the AI agent on Yoga Windows ARM64. SMTP account authentication and real delivery were not tested.contribution_summary: Add an explicit SMTP send command with STARTTLS and isolated SMTP credentials, plus cross-platform test fixes.This draft is not ready to merge until Kagi SMTP authentication is confirmed and a human tests the changes.