Skip to content

26.1#135

Merged
Awakened-Redstone merged 15 commits intoModFest:26.1from
reoseah:26.1
Mar 20, 2026
Merged

26.1#135
Awakened-Redstone merged 15 commits intoModFest:26.1from
reoseah:26.1

Conversation

@reoseah
Copy link

@reoseah reoseah commented Feb 21, 2026

No description provided.

@reoseah
Copy link
Author

reoseah commented Feb 21, 2026

Maybe it would be better if the first three commits (./gradlew migrateMappings to official and manual fixes to mixins and access wideners, tested by running and placing most of the blocks in game successfully) are merged separately, because together this is going to be way too large commit to review

@reoseah
Copy link
Author

reoseah commented Feb 21, 2026

Good news - it runs. Bad news - nothing renders lmao
2026-02-21_22 27 39
2026-02-21_22 27 47

@reoseah
Copy link
Author

reoseah commented Feb 21, 2026

Even better news, I was just using transparent white (0x00FFFFFF) instead of opaque one (0xFFFFFFFF)
2026-02-21_22 32 13

@Awakened-Redstone Awakened-Redstone changed the base branch from 1.21.7 to 26.1 March 18, 2026 14:43
@Awakened-Redstone Awakened-Redstone self-requested a review March 18, 2026 16:14
@Awakened-Redstone Awakened-Redstone self-assigned this Mar 18, 2026
@Awakened-Redstone
Copy link

If GuiRendererMixin managed to still be working since 1.21.7 I will be surprised.

Also, I'll start looking into the PR soon and see if I can merge it, or at least some of it's changes to the 26.1 branch to start working on it.

@reoseah
Copy link
Author

reoseah commented Mar 20, 2026

This was in Discord server, just summarizing here:

  • it used an old version of Loom that doesn't remap mixins, and I didn't know that and updated mixins manually, so there might be some mistakes? I think the item that renders in hand a la map is broken, I would copy project before remapping, bump Loom version, remap to mojmap, and check "properly" remapped code for mixins that might be broken
  • isShiftDown moved from Screen to Minecraft (aka MinecraftClient in Yarn), I searched and couldn't find that and thought it's just gone for good. So, there are places where isShiftDown is commented out (for shift-clicking on increment/decrement buttons to change the value 10x), and can be fixed trivially

Comment on lines +58 to +80
// try {
// afterEvaluate {
// def mixinDep = this.configurations.compileClasspath
// .allDependencies
// .findAll { it.name == "sponge-mixin" }
// .first()
//
// if (mixin != null) {
// def mixinPath = this.configurations.compileClasspath.files(mixinDep).first().path;
//
// println(mixinPath)
//
// vmArg("-javaagent:\"${mixinPath}\"")
//
// println("[Info]: Mixin Hotswap Run should be working")
// } else {
// println("[Warning]: Unable to locate file path for Mixin Jar, HotSwap Run will not work!")
// }
// }
// } catch (Exception e) {
// println("[Error]: MixinHotswap Run had a issue!")
// e.printStackTrace()
// }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this commented?
Did it start throwing an exception when attempting to run?

I don't see why it would be broken on 26.1

Copy link
Author

@reoseah reoseah Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it didn't launch, at least for me. I think it couldn't find mixin jar.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should it be centered at player or be changed to be at the block pos?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it didn't launch, at least for me. I think it couldn't find mixin jar.

Ok. I'll look into it later when I start working on the rest of the port.

@Awakened-Redstone Awakened-Redstone marked this pull request as ready for review March 20, 2026 20:43
@Awakened-Redstone Awakened-Redstone merged commit 5c6138d into ModFest:26.1 Mar 20, 2026
@reoseah
Copy link
Author

reoseah commented Mar 20, 2026

Oh no, I was a bit too slow: 8e1792c
Anyway, I think this changes behavior slightly, so arguably doesn't belong in the pull request about updating to a newer version

@Awakened-Redstone
Copy link

Oh no, I was a bit too slow: 8e1792c Anyway, I think this changes behavior slightly, so arguably doesn't belong in the pull request about updating to a newer version

mhm. I am considering on having this change, but I'll look a bit on it. If I do end adding it I can cherry pick your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants