Skip to content

chore: add docs to pnpm-workspace#196

Merged
kermanx merged 3 commits into
mainfrom
add-docs-to-workspace
May 29, 2026
Merged

chore: add docs to pnpm-workspace#196
kermanx merged 3 commits into
mainfrom
add-docs-to-workspace

Conversation

@kermanx
Copy link
Copy Markdown
Collaborator

@kermanx kermanx commented May 29, 2026

Problem

The docs directory contains a package.json and is a VitePress documentation site, but it is not included in pnpm-workspace.yaml. As a result, pnpm does not manage its dependencies as part of the monorepo workspace.

What changed

Add docs to the packages list in pnpm-workspace.yaml so that the documentation site is properly recognized as a workspace package.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue, or explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 29, 2026

⚠️ No Changeset found

Latest commit: 1bc0b42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c58ac318d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread pnpm-workspace.yaml
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 29, 2026

pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@1bc0b42
npx https://pkg.pr.new/@moonshot-ai/kimi-code@1bc0b42

commit: 1bc0b42

@kermanx kermanx merged commit 8de7204 into main May 29, 2026
8 checks passed
@kermanx kermanx deleted the add-docs-to-workspace branch May 29, 2026 06:34
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bc0b42510

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread pnpm-workspace.yaml
- apps/*
- apps/vis/server
- apps/vis/web
- docs
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the standalone docs install path

Once docs is included in the workspace here, the existing root dev:docs script (package.json line 13) still runs pnpm -C docs install --ignore-workspace before starting VitePress. Because this commit deletes docs/pnpm-lock.yaml, anyone using pnpm run dev:docs now resolves a fresh standalone docs install outside the committed root lockfile and can recreate an untracked docs/pnpm-lock.yaml, so local docs development no longer uses the same dependency graph as CI. Please update that script to rely on the workspace install instead of --ignore-workspace.

Useful? React with 👍 / 👎.

Comment thread pnpm-lock.yaml
Comment on lines +193 to +194
docs:
dependencies:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add Vue as a direct docs dependency

After moving docs into the root workspace and deleting docs/.npmrc's shamefully-hoist=true, this importer no longer exposes transitive packages as if they were direct docs dependencies. The docs still import onMounted from vue in docs/index.md, but vue is only a transitive dependency of VitePress in the lockfile, so a normal pnpm workspace install can leave docs/node_modules/vue unresolved and make pnpm -C docs run build fail when Vite resolves that Markdown import. Please declare vue in docs/package.json so the workspace lockfile installs it for the docs package explicitly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant