Skip to content

Python: keep developer field IDs at or below 254. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanderroosendaal merged 2 commits into from
Oct 10, 2026
Merged

Python: keep developer field IDs at or below 254. #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1870b96
Python: keep developer field IDs at or below 254.
Oct 7, 2026
6485d95
Merge main into python/field-id-limit
Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions python/tests/test_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@ def test_developer_field_ids_are_unique() -> None:
assert len(ids) == len(set(ids))


def test_developer_field_ids_stop_at_254() -> None:
"""field_definition_number is UINT8; 255 is the FIT invalid value."""
for field in DEVELOPER_FIELDS:
assert field.field_id is not None
assert 0 <= field.field_id <= 254


def test_field_lookup() -> None:
assert field_by_id(93).name == "StrokeRate"
assert field_by_name("DriveLength").field_id == 0
Expand Down
Loading