Repository navigation
Python: write stroke rate as cadence256 and rounded cadence. - #33
sanderroosendaal wants to merge 4 commits into
Conversation
Developer field 93 and fractional_cadence are no longer written. 28.5 spm rounds half up to cadence 29. Co-authored-by: Cursor <cursoragent@cursor.com>
JBlaak
left a comment
There was a problem hiding this comment.
Two things before this goes in:
-
Precedence differs between writer and reader.
_native_cadenceprefersstroke_rate,resolve_stroke_ratepreferscadence256. WithRecord(stroke_rate=30, cadence256=28.5)the file gets 30 whilevalidate()checks timing against 28.5. CouldRecordkeep a single stroke-rate attribute (e.g.cadence256in spm, written and read), or at least use the same order in both places? -
The stroke-rate typical-range warning goes dead.
validation.pyonly looks up_TYPICALwhile looping overRECORD_DEVELOPER_ATTRS, andstroke_ratewas mapped through field 93. With 93 removed, the"stroke_rate": (10.0, 100.0)entry is never reached. It needs checking against the resolved rate, plus a test.
The writer now prefers cadence256 over stroke_rate, as resolve_stroke_rate does. The typical-range warning checks the resolved stroke rate. Merges main. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Both points addressed in 83f4431, which also merges
🤖 Generated with Claude Code |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Developer field 93 and fractional_cadence are no longer written. 28.5 spm rounds half up to cadence 29.
Co-authored-by: Cursor cursoragent@cursor.com
Implements the Python side of #16. Should be merged after #16.
The diff against
maincontains only this change.🤖 Generated with Claude Code