Repository navigation
Add #173 and #174 to the 3.1 change log - #177
Merged
mwhosek merged 2 commits intoNov 14, 2026
Merged
Conversation
… 3.1 change log Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
I recommend we update the changlog statement about the NAN fix to make this a little more clear: when we say “a steep segment followed by another segment” we are referring to a broken power law where the lower mass segment is steeper than the higher mass segment. Thus, Kroupa-like IMFs (where the lower mass segment is shallower than the higher mass segement) weren’t affected. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Thanks, updated. I also checked a few more slope combinations on the old code: NaN masses only appear when a segment is steeper than the next higher-mass one (e.g. [-2.3, -1.3], [-2.7, -2.3], [-1.3, -2.3, -2.0]); Kroupa-like slopes such as [-1.3, -2.3] and [-0.3, -1.3, -2.3] give none. |
Collaborator
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the changes from #173 and #174 to the 3.1 change log in
docs/index.rst, under Minor Changes:IMF_broken_powerlaw(Warn before overwriting a mismatched isochrone file; fix NaN IMF masses; NumPy scalars in IMF helpers #173)theta_closed,theta_open, anddeltareturn a float for NumPy scalar input (Warn before overwriting a mismatched isochrone file; fix NaN IMF masses; NumPy scalars in IMF helpers #173)ResolvedClusterlow-mass removal messages printed only whenverbose=True(Warn before overwriting a mismatched isochrone file; fix NaN IMF masses; NumPy scalars in IMF helpers #173)Docs only; no code changes.