⚡ Bolt: Optimize PDF list filtering and rendering overhead#41
⚡ Bolt: Optimize PDF list filtering and rendering overhead#41MrAlokTech wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: MrAlokTech <107493955+MrAlokTech@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying classnotes with
|
| Latest commit: |
8995657
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c5d3caf.classnotes.pages.dev |
| Branch Preview URL: | https://bolt-optimize-pdf-filtering.classnotes.pages.dev |
💡 What:
prepareSearchIndexfunction that runs once during data load (after caching) to pre-calculate a lowercased_searchStr, a formatted date string (_formattedDate), and the "New" badge boolean (_isNew)..filter()inrenderPDFsto use early returns for exact match checks (class, semester, category), and then use a single.includes()check against the pre-calculated_searchStr.createPDFCardto use the pre-calculated_isNewand_formattedDateproperties.🎯 Why:
renderPDFsfunction executes frequently (on every keypress in the search bar).new Date()objects, running.toLocaleDateString(), and performing up to 4.toLowerCase()conversions per PDF card during every single render and filter cycle. This caused unnecessary CPU overhead and potential layout stuttering on lower-end devices as the database grows..filter()forces the JavaScript engine to evaluate parts of the expression even when earlier parts indicate failure.📊 Impact:
🔬 Measurement:
verify_perf.pyconfirms that_searchStris correctly applied to the cache and that search and rendering functions properly without errors.PR created automatically by Jules for task 17707743238453213313 started by @MrAlokTech