Skip to content

⚡ Bolt: Optimize PDF list filtering and rendering overhead#41

Open
MrAlokTech wants to merge 1 commit intomainfrom
bolt-optimize-pdf-filtering-17707743238453213313
Open

⚡ Bolt: Optimize PDF list filtering and rendering overhead#41
MrAlokTech wants to merge 1 commit intomainfrom
bolt-optimize-pdf-filtering-17707743238453213313

Conversation

@MrAlokTech
Copy link
Owner

💡 What:

  • Added a prepareSearchIndex function that runs once during data load (after caching) to pre-calculate a lowercased _searchStr, a formatted date string (_formattedDate), and the "New" badge boolean (_isNew).
  • Refactored the array .filter() in renderPDFs to use early returns for exact match checks (class, semester, category), and then use a single .includes() check against the pre-calculated _searchStr.
  • Refactored createPDFCard to use the pre-calculated _isNew and _formattedDate properties.

🎯 Why:

  • The renderPDFs function executes frequently (on every keypress in the search bar).
  • Previously, it was instantiating multiple new Date() objects, running .toLocaleDateString(), and performing up to 4 .toLowerCase() conversions per PDF card during every single render and filter cycle. This caused unnecessary CPU overhead and potential layout stuttering on lower-end devices as the database grows.
  • Grouping boolean checks in .filter() forces the JavaScript engine to evaluate parts of the expression even when earlier parts indicate failure.

📊 Impact:

  • Eliminates 4 string allocations/lowercasing operations per item per keystroke.
  • Eliminates expensive Date instantiations during the render loop.
  • Reduces filter loop overhead significantly via early returns.

🔬 Measurement:

  • verify_perf.py confirms that _searchStr is correctly applied to the cache and that search and rendering functions properly without errors.

PR created automatically by Jules for task 17707743238453213313 started by @MrAlokTech

Co-authored-by: MrAlokTech <107493955+MrAlokTech@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages
Copy link

Deploying classnotes with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8995657
Status: ✅  Deploy successful!
Preview URL: https://6c5d3caf.classnotes.pages.dev
Branch Preview URL: https://bolt-optimize-pdf-filtering.classnotes.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant