Repository navigation
fix(detection): clarify partial calendar date validation - #335
lipikaramaswamy wants to merge 1 commit into
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryClarifies that
No actionable issues found. Tests were not run during this review. Reviews (3) · Last reviewed commit: "fix(detection): clarify partial calendar..." · Reviewed by Greptile |
asteier2026
left a comment
There was a problem hiding this comment.
One, probably minor, thing we should remember is this does slightly increase the chance of replace propagating changes to instances of the value with different meanings. "March" the month and "march" the verb; "2024" the year and "2024" a quantity. But that is an existing issue we may have to tackle at some point. I wouldn't worry about it now.
Also, I'm presuming you ran the slurm benchmarking and verified prec/recall on datasets like OpenPIIand NemotronPII remain good.
f838c73 to
b2043cd
Compare
Signed-off-by: lipikaramaswamy <lramaswamy@nvidia.com>
b2043cd to
9fa3374
Compare
Related Issue
Fixes #334
Plan Document
No plan required: this is a small clarification to existing date-label guidance, examples, and tests.
Summary
The validator currently keeps dates but drops time references that are not "specific dates", while all built-in date examples are complete dates. This leaves models to decide whether a month or year is specific enough.
Clarify that
dateincludes complete and partial calendar references when context establishes their meaning:Marchin "The appointment is in March"2024in "She joined in 2024"March 2024in "We met in March 2024"the 15thin "The appointment is on the 15th"Keep the requirement for calendar context: "March forward" and "2024 items" are not dates. Preserve the existing exclusion of vague time references such as "today", "now", and "soon".
Align the validator and augmenter instructions, extend the built-in examples, and document the policy. The existing
datelabel remains the umbrella label.Type of Change
Contributor Checklist
Validation
make checkmake test(withTMPDIR=/private/tmpand a short pytest temporary directory for socket-path compatibility)make docs-buildTests verify the generated validator and augmenter guidance and the built-in examples. Live-model behavior remains probabilistic; these are prompt-content tests rather than a model-quality benchmark.
Documentation and Artifacts
make docs-buildpasses locallyPR stack
Merge/review order: #305 → #267 → #335.
main.After a parent is squash-merged, restack the remaining child commits onto the updated parent/
mainand retarget their PRs as appropriate. These links describe dependency order, not approval or CI status.Restack verification (2026-11-04)
Restacked the date-guidance commit onto #267 at
16e9d0d3; the PR adds exactly one commit (b2043cd5, four files, 43 additions and two deletions). The resulting tracked tree is identical to the combined #305 + #267 + #335 candidate02c58f7a.make checkand DCO: passed.git diff --check: passed.