Skip to content

fix(detection): honor configured validator recovery limits - #339

Merged
andreatnvidia merged 2 commits into
mainfrom
andreatnvidia/fix/chunked-validator-recovery
Nov 4, 2026
Merged

andreatnvidia merged 2 commits into
mainfrom
andreatnvidia/fix/chunked-validator-recovery

Conversation

@andreatnvidia

@andreatnvidia andreatnvidia commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Related Issue

No linked issue required: maintainer-owned correction of existing recovery-policy plumbing.

Plan Document

No plan required: internal engine wiring with no new public configuration.

Summary

Chunked entity validation calls the model facade without the conversation recovery limits from DataDesigner's run configuration. A malformed response can therefore drop a record even when recovery is enabled. Forward the configured restart and correction limits through asynchronous validation before trying the next validator alias.

Explicit zero limits remain zero. Exhausted recovery still raises and reports the failed record. Direct helper callers retain their zero-retry defaults.

This change builds on the async-only validation path merged in #359.

Type of Change

  • Bug fix

Contributor Checklist

  • PR title follows Conventional Commits
  • Maintainer-owned no-issue reason documented above
  • No-plan reason documented above
  • Public API impact checked; bundled skill needs no change
  • Test examples contain only synthetic data
  • No credentials or secrets added

Validation

  • TMPDIR=/private/tmp .venv/bin/pytest -q --tb=short --basetemp=/private/tmp/a339-after-359-tests: 1,613 passed with the locked DataDesigner 0.9.4 environment.
  • Chunked-validation suite: 42 passed. Regression tests use the real model facade with scripted transport responses and cover default/configured recovery budgets, explicit zero, exhaustion, and alias failover through async execution.
  • Full-pipeline scripted HTTP smoke in standalone and combined rewrite modes: a malformed validator response drops one of three records on main; this fix recovers it and returns all three with no failed records.
  • .venv/bin/ruff check --fix . && .venv/bin/ruff format .
  • VIRTUAL_ENV="$PWD/.venv" .venv/bin/ty check --error-on-warning
  • .venv/bin/python tools/codestyle/copyright_fixer.py --check .
  • uv lock --check and git diff --check

The format, copyright, and aggregate commit-hook wrappers were skipped after running their equivalent checks directly because they invoke uv run. Remaining applicable hooks and DCO signoff passed. Live model behavior was not retested for this update.

Documentation and Artifacts

  • Internal parameter docstrings updated; no public documentation or notebook changes needed
  • No benchmark data or generated artifacts included

Signed-off-by: Andre Manoel <amanoel@nvidia.com>
@andreatnvidia
andreatnvidia marked this pull request as ready for review October 30, 2026 12:50
@andreatnvidia
andreatnvidia requested a review from a team as a code owner October 30, 2026 12:50
@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Chunked validation now forwards the run's configured restart and correction limits to each validator alias.

  • Chunked validation now uses the run's recovery limits.

Reviews (2) · Last reviewed commit: "Merge main into validator recovery fix" · Reviewed by Greptile

@lipikaramaswamy lipikaramaswamy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed d678e96; no actionable findings. The configured recovery limits are forwarded through both synchronous and asynchronous validation, explicit zero limits are preserved, and recovery occurs before alias failover. The sync-to-async bridge accounts for the recovery budget.

Validation: 135 relevant tests passed against this commit with Data Designer 0.9.4. GitHub test and code-quality checks also pass. Live model behavior was not tested.

Signed-off-by: Andre Manoel <amanoel@nvidia.com>
@andreatnvidia
andreatnvidia merged commit 568207b into main Nov 4, 2026
20 checks passed
@andreatnvidia
andreatnvidia deleted the andreatnvidia/fix/chunked-validator-recovery branch November 4, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants