Repository navigation
fix(detection): honor configured validator recovery limits - #339
Conversation
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryChunked validation now forwards the run's configured restart and correction limits to each validator alias.
Reviews (2) · Last reviewed commit: "Merge main into validator recovery fix" · Reviewed by Greptile |
lipikaramaswamy
left a comment
There was a problem hiding this comment.
Reviewed d678e96; no actionable findings. The configured recovery limits are forwarded through both synchronous and asynchronous validation, explicit zero limits are preserved, and recovery occurs before alias failover. The sync-to-async bridge accounts for the recovery budget.
Validation: 135 relevant tests passed against this commit with Data Designer 0.9.4. GitHub test and code-quality checks also pass. Live model behavior was not tested.
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Related Issue
No linked issue required: maintainer-owned correction of existing recovery-policy plumbing.
Plan Document
No plan required: internal engine wiring with no new public configuration.
Summary
Chunked entity validation calls the model facade without the conversation recovery limits from DataDesigner's run configuration. A malformed response can therefore drop a record even when recovery is enabled. Forward the configured restart and correction limits through asynchronous validation before trying the next validator alias.
Explicit zero limits remain zero. Exhausted recovery still raises and reports the failed record. Direct helper callers retain their zero-retry defaults.
This change builds on the async-only validation path merged in #359.
Type of Change
Contributor Checklist
Validation
TMPDIR=/private/tmp .venv/bin/pytest -q --tb=short --basetemp=/private/tmp/a339-after-359-tests: 1,613 passed with the locked DataDesigner 0.9.4 environment..venv/bin/ruff check --fix . && .venv/bin/ruff format .VIRTUAL_ENV="$PWD/.venv" .venv/bin/ty check --error-on-warning.venv/bin/python tools/codestyle/copyright_fixer.py --check .uv lock --checkandgit diff --checkThe format, copyright, and aggregate commit-hook wrappers were skipped after running their equivalent checks directly because they invoke
uv run. Remaining applicable hooks and DCO signoff passed. Live model behavior was not retested for this update.Documentation and Artifacts