Skip to content

chore(graph-sdk): merge main into the line - #370

Merged
binaryaaron merged 3 commits into
aagonzales/graph-sdk/feat/mainfrom
aagonzales/chore/graph-sdk-merge-main-aca29fcb
Nov 3, 2026
Merged

binaryaaron merged 3 commits into
aagonzales/graph-sdk/feat/mainfrom
aagonzales/chore/graph-sdk-merge-main-aca29fcb

Conversation

@binaryaaron

Copy link
Copy Markdown
Collaborator

Merges main (aca29fc) into the graph SDK line. Main brings #357 and #359; #359 removes the legacy sync model paths, so chunked validation, rewrite evaluation and repair use async model calls only.

Conflicts

  • src/anonymizer/engine/detection/chunked_validation.py: main's removal of the sync path wins. The line's changes to the async path are kept: the validation_chunks() helper, failover logs without alias names or exception text, the pool-size debug log, draining sibling chunk tasks before re-raising, and the failure-contract text. The line's edits to the deleted sync functions go away with them.
  • tests/test_measurement.py: main's async preview in the fake DataDesigner, reading rows from the builder's seed as the line does.

Every other file equals the clean three-way merge. Nothing on the line refers to the names main removed.

Checks

  • make check passes.
  • pytest gives 1615 passed.
  • The spec programs give 111 PASS and 8 RETIRED, the same as before the merge.
  • Parity corpus, the line before the merge against the merge: 0 blocking differences on pandas 2 and 3, with informational differences within run-to-run noise (29 and 37 rows; main against itself gives 29 to 32).
  • Executed-line ratio against main: at most 1.28, under the 1.5 limit.
  • The open PRs stacked on the line each merge cleanly onto this head.

🤖 Generated with Claude Code

lipikaramaswamy and others added 3 commits November 2, 2026 18:02
Signed-off-by: lipikaramaswamy <lramaswamy@nvidia.com>
Use async model calls for chunked validation, rewrite evaluation, and repair; preserve async trace context.

Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
@binaryaaron
binaryaaron requested review from a team as code owners November 3, 2026 19:43
@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were established.

Summary

This merge moves chunked validation, rewrite evaluation, and repair to async model calls while preserving the graph line’s validation helpers and failure cleanup.

  • Entity detection validates chunks through the async model path.
  • Rewrite evaluation and repair await async model calls.
  • Async custom columns keep their column name attached to model traces.
  • The standalone pipeline timing script is removed.
  • The type checker treats notebook-only model imports as optional.

Reviews (1) · Last reviewed commit: "Merge main into the graph SDK line" · Reviewed by Greptile

@binaryaaron
binaryaaron merged commit a22ca8e into aagonzales/graph-sdk/feat/main Nov 3, 2026
6 of 7 checks passed
@binaryaaron
binaryaaron deleted the aagonzales/chore/graph-sdk-merge-main-aca29fcb branch November 3, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants