Repository navigation
Support es_SV (El Salvador) locale in PersonSampler / managed datasets #862
Description
Priority Level
High (Major improvement)
Is your feature request related to a problem? Please describe.
The El Salvador persona dataset is already available, so it would be useful if es_SV could also be supported by the managed person sampler.
Describe the solution you'd like
Support es_SV could also be supported by the managed person sampler.
Describe alternatives you've considered
No response
Agent Investigation
No response
Additional context
No response
Checklist
- I've reviewed existing issues and the documentation
- This is a design proposal, not a "please build this" request
Activity
ting-hong-shieh commentedon Oct 28, 2026
I'd like to help with
es_SV. I checked the official El Salvador dataset and current main4bb221ebbefore starting.The public dataset exists, but its Dataset Viewer schema lacks
first_name,last_name, andlocale, which the current person-record pipeline requires. The CLI also downloads prepared NGC resources rather than that raw Hugging Face dataset. Adding the locale to the constants alone would therefore leave the managed data path unresolved.Is there a prepared
es_SV.parquet/NGC artifact and an intended field mapping to use? With that confirmed, I can cover locale metadata, download/list behavior, sampling validation, and regression tests. Could a maintainer triage this if that contribution is wanted?nabinchha commentedon Nov 6, 2026
Thanks for looking into this and flagging the prepared dataset requirements! The prepared NGC assets are now available, and we already have PR #1136 open to add support for both El Salvador (
es_SV) and Vietnam (vi_VN): #1136.